* [PATCH] staging: rtl8723bs: remove blank line after open brace in hal_com.c
@ 2026-05-03 18:16 Moksh Panicker
2026-05-04 9:28 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Moksh Panicker @ 2026-05-03 18:16 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Moksh Panicker
Remove unnecessary blank line after the opening brace of a for loop.
This fixes the following checkpatch.pl warning:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/hal/hal_com.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index b4b135a9ca22..3c85e96ec57d 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -252,7 +252,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
u8 i, is_brate, brate;
for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
-
is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
brate = mBratesOS[i] & 0x7f;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove blank line after open brace in hal_com.c
2026-05-03 18:16 [PATCH] staging: rtl8723bs: remove blank line after open brace in hal_com.c Moksh Panicker
@ 2026-05-04 9:28 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-05-04 9:28 UTC (permalink / raw)
To: Moksh Panicker; +Cc: devel, linux-kernel
On Sun, May 03, 2026 at 06:16:46PM +0000, Moksh Panicker wrote:
> Remove unnecessary blank line after the opening brace of a for loop.
> This fixes the following checkpatch.pl warning:
>
> CHECK: Blank lines aren't necessary after an open brace '{'
> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index b4b135a9ca22..3c85e96ec57d 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -252,7 +252,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
> u8 i, is_brate, brate;
>
> for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
> -
> is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
> brate = mBratesOS[i] & 0x7f;
>
> --
> 2.34.1
>
For all of your patches you are not sending them to the staging mailing
list, why not? What kernel version are you working off of that shows
the driverdev mailing list as still alive?
Please resend all of your submitted patches to the list that
scripts/get_maintainer.pl shows to send to, as a patch series, and we
will be glad to review them there.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-04 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 18:16 [PATCH] staging: rtl8723bs: remove blank line after open brace in hal_com.c Moksh Panicker
2026-05-04 9:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox