public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	 linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: mmc: st,sdhci: convert to DT schema
Date: Mon, 4 May 2026 09:43:08 +0200	[thread overview]
Message-ID: <20260504-rational-gleaming-clam-aeaaff@quoll> (raw)
In-Reply-To: <20260503-st-mmc-v2-2-11ae3216d2ce@gmail.com>

On Sun, May 03, 2026 at 08:35:30AM +0000, Charan Pedumuru wrote:
> +$id: http://devicetree.org/schemas/mmc/st,sdhci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics SDHCI-ST MMC/SD Controller
> +
> +description:
> +  The STMicroelectronics SDHCI-ST MMC/SD host controller, which is
> +  compliant with the SD Host Controller Interface (SDHCI) specification and
> +  is used to interface with MMC, SD and SDIO cards. The ST SDHCI controller
> +  extends the standard SDHCI capabilities with platform-specific
> +  configurations such as additional register regions,clock inputs, and delay
> +  control mechanisms required for signal timing adjustments which are
> +  necessary to support high-speed modes and ensure reliable data transfer
> +  across different ST SoCs.
> +
> +allOf:
> +  - $ref: mmc-controller.yaml#
> +
> +maintainers:
> +  - Peter Griffin <peter.griffin@linaro.org>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: st,sdhci
> +      - items:
> +          - const: st,sdhci-stih407
> +          - const: st,sdhci
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: Base address and size of the MMC controller registers

s/Base address and size of the//

> +      - description: Base address and size of the MMC delay/auxiliary registers

Here the same

> +
> +  reg-names:
> +    oneOf:
> +      - items:
> +          - const: mmc

Drop three lines above

> +      - items:

So this is just items like you have in "reg" part. Same syntax.

> +          - const: mmc
> +          - const: top-mmc-delay
> +
> +  clocks:

Here and:

> +    items:
> +      - description: Clock for the MMC controller
> +      - description: Interconnect (ICN) clock
> +
> +  clock-names:

here: Old binding icn is optional. You need to explain in the commit msg
all the changes done during conversion.

> +    items:
> +      - const: mmc
> +      - const: icn
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-names:
> +    const: mmcirq
> +
> +  resets:
> +    maxItems: 1

Best regards,
Krzysztof


      reply	other threads:[~2026-05-04  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03  8:35 [PATCH v2 0/2] dt-bindings: mmc: st,sdhci: convert STMicroelectronics SDHCI-ST MMC/SD Controller controller binding to YAML Charan Pedumuru
2026-05-03  8:35 ` [PATCH v2 1/2] arm: dts: st: align node patterns with established convention Charan Pedumuru
2026-05-03  8:35 ` [PATCH v2 2/2] dt-bindings: mmc: st,sdhci: convert to DT schema Charan Pedumuru
2026-05-04  7:43   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504-rational-gleaming-clam-aeaaff@quoll \
    --to=krzk@kernel.org \
    --cc=charan.pedumuru@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox