[PATCH] sched/psi: Skip CPUs with zero non-idle jiffies in per-cpu aggregation

[PATCH] sched/psi: Skip CPUs with zero non-idle jiffies in per-cpu aggregation

[Zhan Xusheng]

PSI per-cpu aggregation weights each CPU's contribution by its
non-idle time converted to jiffies. CPUs with zero non-idle jiffies
do not contribute to the weighted result, but are still processed in
the current implementation.

Skip CPUs with zero non-idle jiffies early to avoid unnecessary
per-cpu arithmetic during aggregation.

No functional change intended.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
 kernel/sched/psi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 59fdb7ebbf22..ce2321793a67 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -387,6 +387,13 @@ static void collect_percpu_times(struct psi_group *group,
 		changed_states |= cpu_changed_states;
 
 		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
+		/*
+		 * A CPU with zero non-idle jiffies does not contribute to the
+		 * weighted per-CPU aggregation. There is no need to include it
+		 * in deltas or total accumulation.
+		 */
+		if (!nonidle)
+			continue;
 		nonidle_total += nonidle;
 
 		for (s = 0; s < PSI_NONIDLE; s++)
-- 
2.43.0

Re: [PATCH] sched/psi: Skip CPUs with zero non-idle jiffies in per-cpu aggregation

[Johannes Weiner]

On Tue, Feb 03, 2026 at 06:00:07PM +0800, Zhan Xusheng wrote:
> PSI per-cpu aggregation weights each CPU's contribution by its
> non-idle time converted to jiffies. CPUs with zero non-idle jiffies
> do not contribute to the weighted result, but are still processed in
> the current implementation.
> 
> Skip CPUs with zero non-idle jiffies early to avoid unnecessary
> per-cpu arithmetic during aggregation.
> 
> No functional change intended.
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>

Makes sense.

> ---
>  kernel/sched/psi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 59fdb7ebbf22..ce2321793a67 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -387,6 +387,13 @@ static void collect_percpu_times(struct psi_group *group,
>  		changed_states |= cpu_changed_states;
>  
>  		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
> +		/*
> +		 * A CPU with zero non-idle jiffies does not contribute to the
> +		 * weighted per-CPU aggregation. There is no need to include it
> +		 * in deltas or total accumulation.
> +		 */
> +		if (!nonidle)
> +			continue;

You could save the nsecs_to_jiffies() dance as well by doing:

		if (!(cpu_changed_states & (1 << PSI_NONIDLE)))
			coninue;

[PATCH v2] sched/psi: Skip CPUs with zero non-idle jiffies in per-CPU aggregation

[Zhan Xusheng]

To improve performance during per-CPU aggregation, skip CPUs that have
zero non-idle jiffies early in the process. These CPUs do not contribute
to the weighted result and can be excluded from the per-CPU calculations.
The change directly checks the `cpu_changed_states` for `PSI_NONIDLE`
instead of performing unnecessary arithmetic.

No functional change intended.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
---
 kernel/sched/psi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 59fdb7ebbf22..f1bf5449d3f9 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -384,6 +384,13 @@ static void collect_percpu_times(struct psi_group *group,
 
 		get_recent_times(group, cpu, aggregator, times,
 				&cpu_changed_states);
+		/*
+		 * Skip CPUs with no non-idle time. These CPUs do not contribute
+		 * to the weighted per-CPU aggregation, so we can avoid unnecessary
+		 * calculations for them by checking cpu_changed_states.
+		 */
+		if (!(cpu_changed_states & (1 << PSI_NONIDLE)))
+			continue;
 		changed_states |= cpu_changed_states;
 
 		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
-- 
2.43.0

[PATCH v3] sched/psi: Skip CPUs with zero non-idle jiffies in per-CPU aggregation

[Zhan Xusheng]

To improve performance during per-CPU aggregation, skip CPUs that have
zero non-idle jiffies early in the process. These CPUs do not contribute
to the weighted result and can be excluded from the per-CPU calculations.
The change directly checks the `cpu_changed_states` for `PSI_NONIDLE`
instead of performing unnecessary arithmetic.

No functional change intended.

Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
---
 kernel/sched/psi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index d9c9d9480a45..65f09282143e 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -384,6 +384,13 @@ static void collect_percpu_times(struct psi_group *group,
 
 		get_recent_times(group, cpu, aggregator, times,
 				&cpu_changed_states);
+		/*
+		 * Skip CPUs with no non-idle time. These CPUs do not contribute
+		 * to the weighted per-CPU aggregation, so we can avoid unnecessary
+		 * calculations for them by checking cpu_changed_states.
+		 */
+		if (!(cpu_changed_states & (1 << PSI_NONIDLE)))
+			continue;
 		changed_states |= cpu_changed_states;
 
 		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
-- 
2.43.0

[PATCH v4] sched/psi: Skip CPUs with zero non-idle delta in per-CPU aggregation

[Zhan Xusheng]

collect_percpu_times() iterates over every possible CPU to build a
non-idle-weighted average of the PSI state times. When a CPU has
no PSI_NONIDLE delta for the current sampling interval:
  nonidle  = nsecs_to_jiffies(times[PSI_NONIDLE]) = 0
  deltas[s] += times[s] * nonidle               /* += 0 */

so the weighted accumulation contributes nothing.

get_recent_times() already sets the PSI_NONIDLE bit in
cpu_changed_states iff the PSI_NONIDLE delta is non-zero. Use that
bit to skip such CPUs early, as suggested by Johannes, avoiding the
nsecs_to_jiffies() call.

No functional change intended.

Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
v4:
 - Drop the incorrect Reviewed-by added in v2/v3; replace with
   Suggested-by. Johannes' "Makes sense." on v1 was an
   acknowledgement and an implementation suggestion, not a review
   tag.
 - Rebase commit message wording to describe "PSI_NONIDLE delta"
   rather than "non-idle jiffies", matching the actual check.
v3: https://lore.kernel.org/all/20260313034847.1422-1-zhanxusheng@xiaomi.com/
 - Resend of v2.
v2: https://lore.kernel.org/all/20260204022328.23938-1-zhanxusheng@xiaomi.com/
 - Use cpu_changed_states & (1 << PSI_NONIDLE) per Johannes'
   suggestion, saving the nsecs_to_jiffies() call.
v1: https://lore.kernel.org/all/20260203100007.22044-1-zhanxusheng@xiaomi.com/
---
 kernel/sched/psi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index d9c9d9480a45..cd1174f0b5e5 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -384,6 +384,13 @@ static void collect_percpu_times(struct psi_group *group,
 
 		get_recent_times(group, cpu, aggregator, times,
 				&cpu_changed_states);
+		/*
+		 * If this CPU's PSI_NONIDLE delta is zero, it contributes
+		 * nothing to nonidle_total or to any deltas[] entry below,
+		 * so skip it early.
+		 */
+		if (!(cpu_changed_states & (1 << PSI_NONIDLE)))
+			continue;
 		changed_states |= cpu_changed_states;
 
 		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]);
-- 
2.43.0

Re: [PATCH v4] sched/psi: Skip CPUs with zero non-idle delta in per-CPU aggregation

[Peter Zijlstra]

On Wed, Apr 29, 2026 at 06:05:55PM +0800, Zhan Xusheng wrote:
> collect_percpu_times() iterates over every possible CPU to build a
> non-idle-weighted average of the PSI state times. When a CPU has
> no PSI_NONIDLE delta for the current sampling interval:
>   nonidle  = nsecs_to_jiffies(times[PSI_NONIDLE]) = 0
>   deltas[s] += times[s] * nonidle               /* += 0 */
> 
> so the weighted accumulation contributes nothing.
> 
> get_recent_times() already sets the PSI_NONIDLE bit in
> cpu_changed_states iff the PSI_NONIDLE delta is non-zero. Use that
> bit to skip such CPUs early, as suggested by Johannes, avoiding the
> nsecs_to_jiffies() call.
> 
> No functional change intended.

So presumably this is an optimization. Where is the data that justifies
this?