* [PATCH] staging: rtl8723bs: hal: add blank line after declaration
@ 2026-04-27 18:34 Shyam Sunder Reddy Padira
2026-04-28 6:56 ` Luka Gejak
2026-05-04 14:48 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Shyam Sunder Reddy Padira @ 2026-04-27 18:34 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Shyam Sunder Reddy Padira
Add missing blank line after variable declarations to comply with
kernel coding style.
Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index 6d5e531505f9..7fac1c2ba8e0 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
@@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
)
{
u16 RegRfMod_BW, u2tmp = 0;
+
RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
switch (CurrentBW) {
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: hal: add blank line after declaration
2026-04-27 18:34 [PATCH] staging: rtl8723bs: hal: add blank line after declaration Shyam Sunder Reddy Padira
@ 2026-04-28 6:56 ` Luka Gejak
2026-05-04 14:48 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Luka Gejak @ 2026-04-28 6:56 UTC (permalink / raw)
To: shyamsunderreddypadira; +Cc: gregkh, linux-kernel, linux-staging, luka.gejak
> Add missing blank line after variable declarations to comply with
> kernel coding style.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 6d5e531505f9..7fac1c2ba8e0 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
> )
> {
> u16 RegRfMod_BW, u2tmp = 0;
> +
> RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
>
> switch (CurrentBW) {
> --
> 2.43.0
>
Hi Shyam,
I am sorry to inform you but someone has does this change already in
the past. You are probably working on mainline or older tree, which is
why this change wasn't present for you. Please work on top of
staging-next branch in the future.
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: hal: add blank line after declaration
2026-04-27 18:34 [PATCH] staging: rtl8723bs: hal: add blank line after declaration Shyam Sunder Reddy Padira
2026-04-28 6:56 ` Luka Gejak
@ 2026-05-04 14:48 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-05-04 14:48 UTC (permalink / raw)
To: Shyam Sunder Reddy Padira; +Cc: linux-staging, linux-kernel
On Tue, Apr 28, 2026 at 12:04:56AM +0530, Shyam Sunder Reddy Padira wrote:
> Add missing blank line after variable declarations to comply with
> kernel coding style.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 6d5e531505f9..7fac1c2ba8e0 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B(
> )
> {
> u16 RegRfMod_BW, u2tmp = 0;
> +
> RegRfMod_BW = rtw_read16(Adapter, REG_TRXPTCL_CTL_8723B);
>
> switch (CurrentBW) {
> --
> 2.43.0
>
>
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-04 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 18:34 [PATCH] staging: rtl8723bs: hal: add blank line after declaration Shyam Sunder Reddy Padira
2026-04-28 6:56 ` Luka Gejak
2026-05-04 14:48 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox