From: David Laight <david.laight.linux@gmail.com>
To: Pedro Falcato <pfalcato@suse.de>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>, Jann Horn <jannh@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mseal: use min/max in mseal_apply
Date: Mon, 4 May 2026 13:36:45 +0100 [thread overview]
Message-ID: <20260504133645.517d7a0b@pumpkin> (raw)
In-Reply-To: <afe2k3jhDIXchVeE@pedro-suse>
On Sun, 3 May 2026 21:58:57 +0100
Pedro Falcato <pfalcato@suse.de> wrote:
> On Sun, May 03, 2026 at 01:59:16PM +0200, Thorsten Blum wrote:
> > Use the type-checked min()/max() macros instead of MIN()/MAX(), which
> > are supposed to be used "for obvious constants only".
>
> Gotta love these macros... FYI this isn't the only wrong usage in the kernel.
I failed to persuade Linus to include a test for __builtin_constant_p((a)|(b)) :-)
-- David
>
> >
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Reviewed-by: Pedro Falcato <pfalcato@suse.de>
>
prev parent reply other threads:[~2026-05-04 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 11:59 [PATCH] mm/mseal: use min/max in mseal_apply Thorsten Blum
2026-05-03 20:58 ` Pedro Falcato
2026-05-04 12:36 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504133645.517d7a0b@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=pfalcato@suse.de \
--cc=thorsten.blum@linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox