[PATCH v1 0/3] staging: rtl8723bs: misc cleanup patches

[PATCH v1 0/3] staging: rtl8723bs: misc cleanup patches

[Moksh Panicker]

This series contains three small cleanup patches for the rtl8723bs
staging driver, fixing checkpatch.pl warnings.

Moksh Panicker (3):
  staging: rtl8723bs: Remove unnecessary braces in rtl8723bs_xmit.c
  staging: rtl8723bs: Remove commented-out dead code in hal_btcoex.c
  staging: rtl8723bs: remove blank line after open brace in hal_com.c

 drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 3 ---
 drivers/staging/rtl8723bs/hal/hal_com.c        | 1 -
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 4 ++--
 3 files changed, 2 insertions(+), 6 deletions(-)

-- 
2.34.1

[PATCH v1 1/3] staging: rtl8723bs: Remove unnecessary braces in rtl8723bs_xmit.c

[Moksh Panicker]

Braces are not necessary for single statement blocks.
This fixes the following checkpatch.pl warning:

WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index ff39077deb69..d30c5e70625a 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -395,9 +395,9 @@ static s32 rtl8723bs_xmit_handler(struct adapter *padapter)
 	spin_lock_bh(&pxmitpriv->lock);
 	ret = rtw_txframes_pending(padapter);
 	spin_unlock_bh(&pxmitpriv->lock);
-	if (ret == 1) {
+	if (ret == 1)
 		goto next;
-	}
+
 
 	return _SUCCESS;
 }
-- 
2.34.1

[PATCH v1 2/3] staging: rtl8723bs: Remove commented-out dead code in hal_btcoex.c

[Moksh Panicker]

Remove three commented-out lines of dead code that are never executed.
Keeping commented-out code is discouraged as it clutters the codebase
and serves no purpose.

Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index 2a2dd60be8bb..aab68aa299c8 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -402,9 +402,6 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)
 
 	case BTC_GET_U1_MAC_PHY_MODE:
 		*pu8 = BTC_SMSP;
-/* 			*pU1Tmp = BTC_DMSP; */
-/* 			*pU1Tmp = BTC_DMDP; */
-/* 			*pU1Tmp = BTC_MP_UNKNOWN; */
 		break;
 
 	case BTC_GET_U1_AP_NUM:
-- 
2.34.1

[PATCH v1 3/3] staging: rtl8723bs: remove blank line after open brace in hal_com.c

[Moksh Panicker]

Remove unnecessary blank line after the opening brace of a for loop.
This fixes the following checkpatch.pl warning:

CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index b4b135a9ca22..3c85e96ec57d 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -252,7 +252,6 @@ void HalSetBrateCfg(struct adapter *Adapter, u8 *mBratesOS, u16 *pBrateCfg)
 	u8 i, is_brate, brate;
 
 	for (i = 0; i < NDIS_802_11_LENGTH_RATES_EX; i++) {
-
 		is_brate = mBratesOS[i] & IEEE80211_BASIC_RATE_MASK;
 		brate = mBratesOS[i] & 0x7f;
 
-- 
2.34.1