public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
@ 2026-05-01 19:15 Selvamani Rajagopal
  2026-05-01 20:36 ` Rob Herring (Arm)
  2026-05-05 13:44 ` Rob Herring
  0 siblings, 2 replies; 10+ messages in thread
From: Selvamani Rajagopal @ 2026-05-01 19:15 UTC (permalink / raw)
  To: Piergiorgio Beruto, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

Add YAML device tree binding for the onsemi NCN26010 and TS2500
IEEE 802.3cg compliant Ethernet transceiver devices.

Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
---
 .../bindings/net/onnn,ncn260xx.yaml           | 71 +++++++++++++++++++
 1 file changed, 71 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml

diff --git a/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
new file mode 100644
index 000000000..198cd7e9d
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: onsemi NCN26010/TS2500 10BASE-T1S MACPHY Ethernet Controllers
+
+maintainers:
+  - Piergiorgio Beruto <Pier.Beruto@onsemi.com>
+  - Selva Rajagopal <Selvamani.Rajagopal@onsemi.com>
+
+description: |
+  The NCN26010 and TS2500 combine a Media Access Controller (MAC) and an
+  Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
+  Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
+  compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
+  transceiver integrated into the NCN26010. The communication between
+  the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
+  MACPHY Serial Interface (TC6).
+
+  Specifications about the NCN26010 can be found at:
+    https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf
+    https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500
+
+allOf:
+  - $ref: /schemas/net/ethernet-controller.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: onnn,ncn260xx
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    description: |
+      Interrupt from MAC-PHY asserted in the event of Receive Chunks
+      Available, Transmit Chunk Credits Available and Extended Status
+      Event.
+    maxItems: 1
+
+  spi-max-frequency:
+    minimum: 15000000
+    maximum: 25000000
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - spi-max-frequency
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      ethernet@0 {
+        compatible = "onnn,ncn260xx";
+        reg = <0>;
+        pinctrl-names = "default";
+        interrupt-parent = <&gpio>;
+        interrupts = <25 2>;
+        status = "okay";
+        spi-max-frequency = <25000000>;
+      };
+    };
--
2.43.0


Public Information

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-01 19:15 [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY Selvamani Rajagopal
@ 2026-05-01 20:36 ` Rob Herring (Arm)
  2026-05-01 21:21   ` Selvamani Rajagopal
  2026-05-05 13:44 ` Rob Herring
  1 sibling, 1 reply; 10+ messages in thread
From: Rob Herring (Arm) @ 2026-05-01 20:36 UTC (permalink / raw)
  To: Selvamani Rajagopal
  Cc: edumazet, conor+dt, devicetree, Piergiorgio Beruto, netdev, kuba,
	davem, andrew+netdev, krzk+dt, pabeni, linux-kernel


On Fri, 01 May 2026 19:15:17 +0000, Selvamani Rajagopal wrote:
> Add YAML device tree binding for the onsemi NCN26010 and TS2500
> IEEE 802.3cg compliant Ethernet transceiver devices.
> 
> Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> ---
>  .../bindings/net/onnn,ncn260xx.yaml           | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/onnn,ncn260xx.example.dtb: ethernet@0 (onnn,ncn260xx): 'pinctrl-0' is a dependency of 'pinctrl-names'
	from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/CY8PR02MB9249D083B637477C254F9B0583322@CY8PR02MB9249.namprd02.prod.outlook.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-01 20:36 ` Rob Herring (Arm)
@ 2026-05-01 21:21   ` Selvamani Rajagopal
  0 siblings, 0 replies; 10+ messages in thread
From: Selvamani Rajagopal @ 2026-05-01 21:21 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: edumazet@google.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, Piergiorgio Beruto,
	netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
	andrew+netdev@lunn.ch, krzk+dt@kernel.org, pabeni@redhat.com,
	linux-kernel@vger.kernel.org

Thanks. I did verify with dt_binding_check. Will update and re-run

Sincerely
Selva

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: Friday, May 1, 2026 1:36 PM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> Cc: edumazet@google.com; conor+dt@kernel.org; devicetree@vger.kernel.org;
> Piergiorgio Beruto <Pier.Beruto@onsemi.com>; netdev@vger.kernel.org;
> kuba@kernel.org; davem@davemloft.net; andrew+netdev@lunn.ch; krzk+dt@kernel.org;
> pabeni@redhat.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
> 10BASE-T1S MACPHY
> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> 
> On Fri, 01 May 2026 19:15:17 +0000, Selvamani Rajagopal wrote:
> > Add YAML device tree binding for the onsemi NCN26010 and TS2500
> > IEEE 802.3cg compliant Ethernet transceiver devices.
> >
> > Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > ---
> > .../bindings/net/onnn,ncn260xx.yaml | 71 +++++++++++++++++++
> > 1 file changed, 71 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/net/onnn,ncn260xx.example.dtb: ethernet@0
> (onnn,ncn260xx): 'pinctrl-0' is a dependency of 'pinctrl-names'
> from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml
> <https://url.usb.m.mimecastprotect.com/s/VZmaCzqg1RhMKNXAMigiLU9M-
> 1W?domain=devicetree.org>
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://patchwork.kernel.org/project/devicetree/patch/CY8PR02MB9249D083B637477C25
> 4F9B0583322@CY8PR02MB9249.namprd02.prod.outlook.com
> <https://patchwork.kernel.org/project/devicetree/patch/CY8PR02MB9249D083B637477C254F9B0583322@CY8PR02MB9249.namprd02.prod.outlook.com
> patchwork.kernel.org>
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-01 19:15 [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY Selvamani Rajagopal
  2026-05-01 20:36 ` Rob Herring (Arm)
@ 2026-05-05 13:44 ` Rob Herring
  2026-05-05 15:11   ` Selvamani Rajagopal
  1 sibling, 1 reply; 10+ messages in thread
From: Rob Herring @ 2026-05-05 13:44 UTC (permalink / raw)
  To: Selvamani Rajagopal
  Cc: Piergiorgio Beruto, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org

On Fri, May 01, 2026 at 07:15:17PM +0000, Selvamani Rajagopal wrote:
> Add YAML device tree binding for the onsemi NCN26010 and TS2500
> IEEE 802.3cg compliant Ethernet transceiver devices.
> 
> Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> ---
>  .../bindings/net/onnn,ncn260xx.yaml           | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> new file mode 100644
> index 000000000..198cd7e9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: onsemi NCN26010/TS2500 10BASE-T1S MACPHY Ethernet Controllers
> +
> +maintainers:
> +  - Piergiorgio Beruto <Pier.Beruto@onsemi.com>
> +  - Selva Rajagopal <Selvamani.Rajagopal@onsemi.com>
> +
> +description: |
> +  The NCN26010 and TS2500 combine a Media Access Controller (MAC) and an
> +  Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
> +  Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
> +  compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
> +  transceiver integrated into the NCN26010. The communication between
> +  the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
> +  MACPHY Serial Interface (TC6).
> +
> +  Specifications about the NCN26010 can be found at:
> +    https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf
> +    https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500
> +
> +allOf:
> +  - $ref: /schemas/net/ethernet-controller.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: onnn,ncn260xx

Don't use wildcards in compatible strings.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    description: |

Don't need '|'.

> +      Interrupt from MAC-PHY asserted in the event of Receive Chunks
> +      Available, Transmit Chunk Credits Available and Extended Status
> +      Event.
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    minimum: 15000000

A minimum is strange. What if you have a board issue requiring lower 
frequency?

> +    maximum: 25000000
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - spi-max-frequency

Normally this is not required. It's only for boards which can't operate 
at the maximum frequency of the device.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ethernet@0 {
> +        compatible = "onnn,ncn260xx";
> +        reg = <0>;
> +        pinctrl-names = "default";
> +        interrupt-parent = <&gpio>;
> +        interrupts = <25 2>;
> +        status = "okay";

Drop. Examples are always enabled.

> +        spi-max-frequency = <25000000>;
> +      };
> +    };
> --
> 2.43.0
> 
> 
> Public Information

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-05 13:44 ` Rob Herring
@ 2026-05-05 15:11   ` Selvamani Rajagopal
  2026-05-05 17:27     ` Andrew Lunn
  0 siblings, 1 reply; 10+ messages in thread
From: Selvamani Rajagopal @ 2026-05-05 15:11 UTC (permalink / raw)
  To: Rob Herring
  Cc: Piergiorgio Beruto, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	krzk+dt@kernel.org, conor+dt@kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, May 5, 2026 6:45 AM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> Cc: Piergiorgio Beruto <Pier.Beruto@onsemi.com>; andrew+netdev@lunn.ch;
> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> krzk+dt@kernel.org; conor+dt@kernel.org; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
> 10BASE-T1S MACPHY
> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> On Fri, May 01, 2026 at 07:15:17PM +0000, Selvamani Rajagopal wrote:
> > Add YAML device tree binding for the onsemi NCN26010 and TS2500
> > IEEE 802.3cg compliant Ethernet transceiver devices.
> >
> > Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > ---
> > .../bindings/net/onnn,ncn260xx.yaml | 71 +++++++++++++++++++
> > 1 file changed, 71 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> > new file mode 100644
> > index 000000000..198cd7e9d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml
> > @@ -0,0 +1,71 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#
> <http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#
> vicetree.org>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> <http://devicetree.org/meta-schemas/core.yaml#
> n=devicetree.org>
> > +
> > +title: onsemi NCN26010/TS2500 10BASE-T1S MACPHY Ethernet Controllers
> > +
> > +maintainers:
> > + - Piergiorgio Beruto <Pier.Beruto@onsemi.com>
> > + - Selva Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > +
> > +description: |
> > + The NCN26010 and TS2500 combine a Media Access Controller (MAC) and an
> > + Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
> > + Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
> > + compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
> > + transceiver integrated into the NCN26010. The communication between
> > + the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
> > + MACPHY Serial Interface (TC6).
> > +
> > + Specifications about the NCN26010 can be found at:
> > + https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf
> <https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf
> n=onsemi.com>
> > + https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500
> <https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500
> semi.com>
> > +
> > +allOf:
> > + - $ref: /schemas/net/ethernet-controller.yaml#
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: onnn,ncn260xx
> 
> Don't use wildcards in compatible strings.
> 
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + description: |
> 
> Don't need '|'.
> 
> > + Interrupt from MAC-PHY asserted in the event of Receive Chunks
> > + Available, Transmit Chunk Credits Available and Extended Status
> > + Event.
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + minimum: 15000000
> 
> A minimum is strange. What if you have a board issue requiring lower
> frequency?

Had the same question in internal review. Datasheet says the minimum speed 15 MHz is needed. That's why we had placed.

> 
> > + maximum: 25000000
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - spi-max-frequency
> 
> Normally this is not required. It's only for boards which can't operate
> at the maximum frequency of the device.
> 
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethernet@0 {
> > + compatible = "onnn,ncn260xx";
> > + reg = <0>;
> > + pinctrl-names = "default";
> > + interrupt-parent = <&gpio>;
> > + interrupts = <25 2>;
> > + status = "okay";
> 
> Drop. Examples are always enabled.
> 
> > + spi-max-frequency = <25000000>;
> > + };
> > + };
> > --
> > 2.43.0
> >
> >
> > Public Information


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-05 15:11   ` Selvamani Rajagopal
@ 2026-05-05 17:27     ` Andrew Lunn
  2026-05-05 17:33       ` Selvamani Rajagopal
       [not found]       ` <DM8PR02MB8021DB41F30E52D3DED9E7329D3E2@DM8PR02MB8021.namprd02.prod.outlook.com>
  0 siblings, 2 replies; 10+ messages in thread
From: Andrew Lunn @ 2026-05-05 17:27 UTC (permalink / raw)
  To: Selvamani Rajagopal
  Cc: Rob Herring, Piergiorgio Beruto, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

> Had the same question in internal review. Datasheet says the minimum
> speed 15 MHz is needed. That's why we had placed.

Could you try it at lower speeds. What happens?

Since it is a 10Mbps media, if the SPI speed is lower than 15MHz,
maybe it cannot keep up with the media? But this clock speed on its
own is not the deciding factor, there could be other users of the SPI
bus. I would expect the driver and device to keep working if the SPI
bus is saturated, just not give the full 10Mbps. And it would also be
a good test the device and driver do work correctly when the bus is
saturated.

	Andrew

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-05 17:27     ` Andrew Lunn
@ 2026-05-05 17:33       ` Selvamani Rajagopal
  2026-05-05 19:01         ` Andrew Lunn
       [not found]       ` <DM8PR02MB8021DB41F30E52D3DED9E7329D3E2@DM8PR02MB8021.namprd02.prod.outlook.com>
  1 sibling, 1 reply; 10+ messages in thread
From: Selvamani Rajagopal @ 2026-05-05 17:33 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Rob Herring, Piergiorgio Beruto, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, May 5, 2026 10:28 AM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> Cc: Rob Herring <robh@kernel.org>; Piergiorgio Beruto <Pier.Beruto@onsemi.com>;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; krzk+dt@kernel.org; conor+dt@kernel.org;
> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
> 10BASE-T1S MACPHY
> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> > Had the same question in internal review. Datasheet says the minimum
> > speed 15 MHz is needed. That's why we had placed.
> 
> Could you try it at lower speeds. What happens?
> 
> Since it is a 10Mbps media, if the SPI speed is lower than 15MHz,
> maybe it cannot keep up with the media? But this clock speed on its
> own is not the deciding factor, there could be other users of the SPI
> bus. I would expect the driver and device to keep working if the SPI
> bus is saturated, just not give the full 10Mbps. And it would also be
> a good test the device and driver do work correctly when the bus is
> saturated.


I should have given more information. If we configure SPI at lower speed, it may start losing frames as it can't sustain the PHY's speed. Please let me know If I should remove it. 

> 
> Andrew


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-05 17:33       ` Selvamani Rajagopal
@ 2026-05-05 19:01         ` Andrew Lunn
  2026-05-05 19:05           ` Selvamani Rajagopal
  0 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2026-05-05 19:01 UTC (permalink / raw)
  To: Selvamani Rajagopal
  Cc: Rob Herring, Piergiorgio Beruto, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

> > Since it is a 10Mbps media, if the SPI speed is lower than 15MHz,
> > maybe it cannot keep up with the media? But this clock speed on its
> > own is not the deciding factor, there could be other users of the SPI
> > bus. I would expect the driver and device to keep working if the SPI
> > bus is saturated, just not give the full 10Mbps. And it would also be
> > a good test the device and driver do work correctly when the bus is
> > saturated.
> 
> 

> I should have given more information. If we configure SPI at lower
> speed, it may start losing frames as it can't sustain the PHY's
> speed. Please let me know If I should remove it.

So it is not really a requirement. Please add a comment that at speed
of at least 15MHz is recommended in order to obtain line rate
performance.

   Andrew

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
  2026-05-05 19:01         ` Andrew Lunn
@ 2026-05-05 19:05           ` Selvamani Rajagopal
  0 siblings, 0 replies; 10+ messages in thread
From: Selvamani Rajagopal @ 2026-05-05 19:05 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Rob Herring, Piergiorgio Beruto, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org



> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, May 5, 2026 12:02 PM
> To: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> Cc: Rob Herring <robh@kernel.org>; Piergiorgio Beruto <Pier.Beruto@onsemi.com>;
> andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; krzk+dt@kernel.org; conor+dt@kernel.org;
> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
> 10BASE-T1S MACPHY
> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> > > Since it is a 10Mbps media, if the SPI speed is lower than 15MHz,
> > > maybe it cannot keep up with the media? But this clock speed on its
> > > own is not the deciding factor, there could be other users of the SPI
> > > bus. I would expect the driver and device to keep working if the SPI
> > > bus is saturated, just not give the full 10Mbps. And it would also be
> > > a good test the device and driver do work correctly when the bus is
> > > saturated.
> >
> >
> 
> > I should have given more information. If we configure SPI at lower
> > speed, it may start losing frames as it can't sustain the PHY's
> > speed. Please let me know If I should remove it.
> 
> So it is not really a requirement. Please add a comment that at speed
> of at least 15MHz is recommended in order to obtain line rate
> performance.

Will; do, along with changes to take care of other comments for the same file.
Thanks

> 
> Andrew


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY
       [not found]       ` <DM8PR02MB8021DB41F30E52D3DED9E7329D3E2@DM8PR02MB8021.namprd02.prod.outlook.com>
@ 2026-05-05 21:25         ` Andrew Lunn
  0 siblings, 0 replies; 10+ messages in thread
From: Andrew Lunn @ 2026-05-05 21:25 UTC (permalink / raw)
  To: Piergiorgio Beruto
  Cc: Selvamani Rajagopal, Rob Herring, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

> As far as I’m concerned, we can remove the 15 MHz lower limit, but I would
> leave some note somewhere if possible.

A comment in the device tree binding next to the maximum speed
requirement would make sense.

	Andrew

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-05-05 21:25 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 19:15 [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010 10BASE-T1S MACPHY Selvamani Rajagopal
2026-05-01 20:36 ` Rob Herring (Arm)
2026-05-01 21:21   ` Selvamani Rajagopal
2026-05-05 13:44 ` Rob Herring
2026-05-05 15:11   ` Selvamani Rajagopal
2026-05-05 17:27     ` Andrew Lunn
2026-05-05 17:33       ` Selvamani Rajagopal
2026-05-05 19:01         ` Andrew Lunn
2026-05-05 19:05           ` Selvamani Rajagopal
     [not found]       ` <DM8PR02MB8021DB41F30E52D3DED9E7329D3E2@DM8PR02MB8021.namprd02.prod.outlook.com>
2026-05-05 21:25         ` Andrew Lunn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox