* [PATCH] ALSA: sparc/dbri: add missing fallthrough
@ 2026-05-06 3:18 Rosen Penev
2026-05-06 8:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-06 3:18 UTC (permalink / raw)
To: linux-sound; +Cc: Jaroslav Kysela, Takashi Iwai, open list
Fixes compiler error with probably newer compilers:
sound/sparc/dbri.c:595:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
595 | case 1:
| ^
sound/sparc/dbri.c:595:2: note: insert 'break;' to avoid fall-through
595 | case 1:
| ^
| break;
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
sound/sparc/dbri.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 75f82a92ff44..2f5f62079fa4 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -592,6 +592,7 @@ static __u32 reverse_bytes(__u32 b, int len)
fallthrough;
case 2:
b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1);
+ fallthrough;
case 1:
case 0:
break;
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: sparc/dbri: add missing fallthrough
2026-05-06 3:18 [PATCH] ALSA: sparc/dbri: add missing fallthrough Rosen Penev
@ 2026-05-06 8:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-05-06 8:08 UTC (permalink / raw)
To: Rosen Penev; +Cc: linux-sound, Jaroslav Kysela, Takashi Iwai, open list
On Wed, 06 May 2026 05:18:54 +0200,
Rosen Penev wrote:
>
> Fixes compiler error with probably newer compilers:
>
> sound/sparc/dbri.c:595:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
> 595 | case 1:
> | ^
> sound/sparc/dbri.c:595:2: note: insert 'break;' to avoid fall-through
> 595 | case 1:
> | ^
> | break;
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-06 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 3:18 [PATCH] ALSA: sparc/dbri: add missing fallthrough Rosen Penev
2026-05-06 8:08 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox