public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema
@ 2026-05-06 17:02 Andrew Rembrandt
  2026-05-06 17:10 ` Linus Walleij
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Andrew Rembrandt @ 2026-05-06 17:02 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij
  Cc: devicetree, linux-arm-kernel, linux-kernel, Andrew Rembrandt

Convert the ST Nomadik boards binding from free-form text to DT schema.

The binding documents the Nomadik NHK15/USB-S8815 platform compatibles
and keeps the existing example.

Signed-off-by: Andrew Rembrandt <kernel@rembrandt.dev>
---
 .../devicetree/bindings/arm/st,nomadik.yaml   | 36 ++++++++++++++++++
 .../devicetree/bindings/arm/ste-nomadik.txt   | 38 -------------------
 MAINTAINERS                                   |  2 +-
 3 files changed, 37 insertions(+), 39 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/st,nomadik.yaml
 delete mode 100644 Documentation/devicetree/bindings/arm/ste-nomadik.txt

diff --git a/Documentation/devicetree/bindings/arm/st,nomadik.yaml b/Documentation/devicetree/bindings/arm/st,nomadik.yaml
new file mode 100644
index 000000000000..9a6d1458cad3
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/st,nomadik.yaml
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/st,nomadik.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST Nomadik SoC based Boards
+
+maintainers:
+  - Linus Walleij <linusw@kernel.org>
+
+description: |
+  Boards using the Nomadik SoC platform
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - const: st,nomadik-nhk-15
+      - const: calaosystems,usb-s8815
+
+additionalProperties: true
+
+examples:
+  - |
+    usb-s8815 {
+        ethernet-gpio {
+            gpios = <&gpio3 19 0x1>;
+            interrupts = <19 0x1>;
+            interrupt-parent = <&gpio3>;
+        };
+        mmcsd-gpio {
+            gpios = <&gpio3 16 0x1>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/arm/ste-nomadik.txt b/Documentation/devicetree/bindings/arm/ste-nomadik.txt
deleted file mode 100644
index 2fdff5a806cf..000000000000
--- a/Documentation/devicetree/bindings/arm/ste-nomadik.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-ST-Ericsson Nomadik Device Tree Bindings
-
-For various board the "board" node may contain specific properties
-that pertain to this particular board, such as board-specific GPIOs.
-
-Required root node property: src
-- Nomadik System and reset controller used for basic chip control, clock
-  and reset line control.
-- compatible: must be "stericsson,nomadik,src"
-
-Boards with the Nomadik SoC include:
-
-Nomadik NHK-15 board manufactured by ST Microelectronics:
-
-Required root node property:
-
-compatible="st,nomadik-nhk-15";
-
-S8815 "MiniKit" manufactured by Calao Systems:
-
-Required root node property:
-
-compatible="calaosystems,usb-s8815";
-
-Required node: usb-s8815
-
-Example:
-
-usb-s8815 {
-		ethernet-gpio {
-			gpios = <&gpio3 19 0x1>;
-			interrupts = <19 0x1>;
-			interrupt-parent = <&gpio3>;
-		};
-		mmcsd-gpio {
-			gpios = <&gpio3 16 0x1>;
-		};
-};
diff --git a/MAINTAINERS b/MAINTAINERS
index 2fb1c75afd16..86e7c1dd51ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3155,7 +3155,7 @@ M:	Linus Walleij <linusw@kernel.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git
-F:	Documentation/devicetree/bindings/arm/ste-*
+F:	Documentation/devicetree/bindings/arm/st,nomadik.yaml
 F:	Documentation/devicetree/bindings/arm/ux500.yaml
 F:	Documentation/devicetree/bindings/arm/ux500/
 F:	Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema
  2026-05-06 17:02 [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema Andrew Rembrandt
@ 2026-05-06 17:10 ` Linus Walleij
  2026-05-06 17:31 ` Conor Dooley
  2026-05-06 18:23 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2026-05-06 17:10 UTC (permalink / raw)
  To: Andrew Rembrandt
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-kernel

On Wed, May 6, 2026 at 7:03 PM Andrew Rembrandt <kernel@rembrandt.dev> wrote:

> Convert the ST Nomadik boards binding from free-form text to DT schema.
>
> The binding documents the Nomadik NHK15/USB-S8815 platform compatibles
> and keeps the existing example.
>
> Signed-off-by: Andrew Rembrandt <kernel@rembrandt.dev>

Sweet, I love it!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema
  2026-05-06 17:02 [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema Andrew Rembrandt
  2026-05-06 17:10 ` Linus Walleij
@ 2026-05-06 17:31 ` Conor Dooley
  2026-05-06 18:23 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2026-05-06 17:31 UTC (permalink / raw)
  To: Andrew Rembrandt
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]

On Wed, May 06, 2026 at 07:02:36PM +0200, Andrew Rembrandt wrote:
> Convert the ST Nomadik boards binding from free-form text to DT schema.
> 
> The binding documents the Nomadik NHK15/USB-S8815 platform compatibles
> and keeps the existing example.
> 
> Signed-off-by: Andrew Rembrandt <kernel@rembrandt.dev>
> ---
>  .../devicetree/bindings/arm/st,nomadik.yaml   | 36 ++++++++++++++++++
>  .../devicetree/bindings/arm/ste-nomadik.txt   | 38 -------------------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 37 insertions(+), 39 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/st,nomadik.yaml
>  delete mode 100644 Documentation/devicetree/bindings/arm/ste-nomadik.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/st,nomadik.yaml b/Documentation/devicetree/bindings/arm/st,nomadik.yaml
> new file mode 100644
> index 000000000000..9a6d1458cad3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/st,nomadik.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/st,nomadik.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST Nomadik SoC based Boards
> +
> +maintainers:
> +  - Linus Walleij <linusw@kernel.org>
> +
> +description: |
> +  Boards using the Nomadik SoC platform
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - const: st,nomadik-nhk-15
> +      - const: calaosystems,usb-s8815
> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    usb-s8815 {
> +        ethernet-gpio {
> +            gpios = <&gpio3 19 0x1>;
> +            interrupts = <19 0x1>;
> +            interrupt-parent = <&gpio3>;
> +        };
> +        mmcsd-gpio {
> +            gpios = <&gpio3 16 0x1>;
> +        };
> +    };

This example should just be removed, it has nothing to do with what's in
the binding above. The text binding describes it as a "required node",
but no node by the name appears in the kernel sources.

With it gone,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

pw-bot: changes-requested

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema
  2026-05-06 17:02 [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema Andrew Rembrandt
  2026-05-06 17:10 ` Linus Walleij
  2026-05-06 17:31 ` Conor Dooley
@ 2026-05-06 18:23 ` Rob Herring (Arm)
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-05-06 18:23 UTC (permalink / raw)
  To: Andrew Rembrandt
  Cc: linux-arm-kernel, Conor Dooley, Linus Walleij, linux-kernel,
	devicetree, Krzysztof Kozlowski


On Wed, 06 May 2026 19:02:36 +0200, Andrew Rembrandt wrote:
> Convert the ST Nomadik boards binding from free-form text to DT schema.
> 
> The binding documents the Nomadik NHK15/USB-S8815 platform compatibles
> and keeps the existing example.
> 
> Signed-off-by: Andrew Rembrandt <kernel@rembrandt.dev>
> ---
>  .../devicetree/bindings/arm/st,nomadik.yaml   | 36 ++++++++++++++++++
>  .../devicetree/bindings/arm/ste-nomadik.txt   | 38 -------------------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 37 insertions(+), 39 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/st,nomadik.yaml
>  delete mode 100644 Documentation/devicetree/bindings/arm/ste-nomadik.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/st,nomadik.yaml: properties:compatible:oneOf: [{'const': 'st,nomadik-nhk-15'}, {'const': 'calaosystems,usb-s8815'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
	hint: Use 'enum' rather than 'oneOf' + 'const' entries
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/st,nomadik.example.dtb: usb-s8815: ethernet-gpio: {'gpios': [[4294967295, 19, 1]], 'interrupts': [[19, 1]]} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/st,nomadik.example.dtb: usb-s8815: mmcsd-gpio: {'gpios': [[4294967295, 16, 1]]} is not of type 'array'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260506170236.2610955-1-kernel@rembrandt.dev

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-06 18:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 17:02 [PATCH] dt-bindings: arm: st,nomadik: Convert to DT schema Andrew Rembrandt
2026-05-06 17:10 ` Linus Walleij
2026-05-06 17:31 ` Conor Dooley
2026-05-06 18:23 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox