* Re: [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument [not found] ` <20260429165229.GF2686-mkhalfella@purestorage.com> @ 2026-05-06 21:57 ` Jacob Keller 2026-05-06 22:49 ` Mohamed Khalfella 0 siblings, 1 reply; 2+ messages in thread From: Jacob Keller @ 2026-05-06 21:57 UTC (permalink / raw) To: Mohamed Khalfella, Paul Menzel Cc: Tony Nguyen, Przemek Kitszel, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan, netdev, linux-kernel On 4/29/2026 9:52 AM, Mohamed Khalfella wrote: > On Wed 2026-04-29 13:02:00 +0200, Paul Menzel wrote: >> Dear Mohamed, >> >> >> Thank you for your patch. >> >> Am 28.04.26 um 20:14 schrieb Mohamed Khalfella: >>> i40e_debug() macro takes struct i40e_hw *h as first argument. But the >>> macro body uses hw instead of h. This has been working so far because hw >>> happen to be the name of the variable in the context where the marco is >> >> marco → ma*cr*o > > Good catch. Also 'happen' should be 'happens' > >> >>> expanded. Fix the macro to use the passed argument. >> >> I’d add a Fixes: tag, but the maintainers might have more input. > > Yes, I should have added Fixes: tag. I will leave it to the maintainer > to decide if v2 is needed to fix the spelling mistakes and add Fixes > tag. > > Fixes: 5dfd37c37a44 ("i40e: Split i40e_osdep.h") > Please send a v2 with the fixes tag and typo. It will make it easier to avoid losing this data. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument 2026-05-06 21:57 ` [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument Jacob Keller @ 2026-05-06 22:49 ` Mohamed Khalfella 0 siblings, 0 replies; 2+ messages in thread From: Mohamed Khalfella @ 2026-05-06 22:49 UTC (permalink / raw) To: Jacob Keller Cc: Paul Menzel, Tony Nguyen, Przemek Kitszel, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan, netdev, linux-kernel On Wed 2026-05-06 14:57:26 -0700, Jacob Keller wrote: > On 4/29/2026 9:52 AM, Mohamed Khalfella wrote: > > On Wed 2026-04-29 13:02:00 +0200, Paul Menzel wrote: > >> Dear Mohamed, > >> > >> > >> Thank you for your patch. > >> > >> Am 28.04.26 um 20:14 schrieb Mohamed Khalfella: > >>> i40e_debug() macro takes struct i40e_hw *h as first argument. But the > >>> macro body uses hw instead of h. This has been working so far because hw > >>> happen to be the name of the variable in the context where the marco is > >> > >> marco → ma*cr*o > > > > Good catch. Also 'happen' should be 'happens' > > > >> > >>> expanded. Fix the macro to use the passed argument. > >> > >> I’d add a Fixes: tag, but the maintainers might have more input. > > > > Yes, I should have added Fixes: tag. I will leave it to the maintainer > > to decide if v2 is needed to fix the spelling mistakes and add Fixes > > tag. > > > > Fixes: 5dfd37c37a44 ("i40e: Split i40e_osdep.h") > > > Please send a v2 with the fixes tag and typo. It will make it easier to > avoid losing this data. Done https://lore.kernel.org/all/20260506224123.691160-1-mkhalfella@purestorage.com/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-06 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260428181450.2622899-1-mkhalfella@purestorage.com>
[not found] ` <558971b7-caea-471a-8fe2-73ba6cc0790a@molgen.mpg.de>
[not found] ` <20260429165229.GF2686-mkhalfella@purestorage.com>
2026-05-06 21:57 ` [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument Jacob Keller
2026-05-06 22:49 ` Mohamed Khalfella
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox