From: "William A. Kennington III" <william@wkennington.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
"William A. Kennington III" <william@wkennington.com>
Subject: [PATCH v4 0/4] i2c: designware: Improve device disable handling
Date: Thu, 07 May 2026 20:05:14 +0000 [thread overview]
Message-ID: <20260507-dw-i2c-v4-0-9a447b23bfdf@wkennington.com> (raw)
When the I2C controller attempts a new transaction while the target
controller is shutting down or restarting, it can lead to bus lockups
and system bootloops if the hardware enters an inconsistent state.
This patch series addresses this by ensuring that the internal state
machines are properly cleared when disabling the controller if target
activity is detected.
Additionally, it adds a shutdown hook that gracefully sets the target
disable bit before disabling the controller. This guarantees that any
incoming requests from the controller are immediately NACKed during
shutdown, preventing the bus from hanging.
Signed-off-by: William A. Kennington III <william@wkennington.com>
---
Changes in v4:
- Updated language to use inclusive terms
- Refactored some minor comment / code nits
- Link to v3: https://lore.kernel.org/r/20260504-dw-i2c-v3-0-57e56135d602@wkennington.com
Changes in v3:
- Split the monolithic patch into 4 logical patches
- Reverted stray formatting change in the PCI driver's dw_i2c_driver struct.
Changes in v2:
- Fix description footers
- Fix emails
---
William A. Kennington III (4):
i2c: designware: Introduce shutdown exported function
i2c: designware: Convert PCI driver to use shutdown hook
i2c: designware: Convert platform driver to use shutdown hook
i2c: designware: Handle active target cleanly
drivers/i2c/busses/i2c-designware-common.c | 32 +++++++++++++++++++++++++++++
drivers/i2c/busses/i2c-designware-core.h | 1 +
drivers/i2c/busses/i2c-designware-master.c | 31 +++++++++++++++++-----------
drivers/i2c/busses/i2c-designware-pcidrv.c | 14 +++++++++++++
drivers/i2c/busses/i2c-designware-platdrv.c | 14 +++++++++++++
5 files changed, 80 insertions(+), 12 deletions(-)
---
base-commit: 5862221fddede6bb15566ab3c1f23a3c353da5e1
change-id: 20260504-dw-i2c-d5a1b1a0036a
Best regards,
--
William A. Kennington III <william@wkennington.com>
next reply other threads:[~2026-05-07 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 20:05 William A. Kennington III [this message]
2026-05-07 20:05 ` [PATCH v4 1/4] i2c: designware: Introduce shutdown exported function William A. Kennington III
2026-05-08 8:12 ` Andy Shevchenko
2026-05-08 10:01 ` Andy Shevchenko
2026-05-07 20:05 ` [PATCH v4 2/4] i2c: designware: Convert PCI driver to use shutdown hook William A. Kennington III
2026-05-08 8:15 ` Andy Shevchenko
2026-05-11 19:55 ` William A. Kennington III
2026-05-07 20:05 ` [PATCH v4 3/4] i2c: designware: Convert platform " William A. Kennington III
2026-05-08 8:15 ` Andy Shevchenko
2026-05-11 19:55 ` William A. Kennington III
2026-05-07 20:05 ` [PATCH v4 4/4] i2c: designware: Handle active target cleanly William A. Kennington III
2026-05-08 10:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507-dw-i2c-v4-0-9a447b23bfdf@wkennington.com \
--to=william@wkennington.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox