From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "William A. Kennington III" <william@wkennington.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] i2c: designware: Convert PCI driver to use shutdown hook
Date: Fri, 8 May 2026 11:15:05 +0300 [thread overview]
Message-ID: <af2biS8SRkeNtGDC@ashevche-desk.local> (raw)
In-Reply-To: <20260507-dw-i2c-v4-2-9a447b23bfdf@wkennington.com>
On Thu, May 07, 2026 at 08:05:16PM +0000, William A. Kennington III wrote:
> Convert the PCI driver to use the new i2c_dw_shutdown() hook, allowing
> the controller to gracefully NACK master requests during system shutdown.
...
> +static void i2c_dw_pci_shutdown(struct pci_dev *pdev)
> +{
> + struct dw_i2c_dev *i_dev;
> +
> + i_dev = pci_get_drvdata(pdev);
> + if (!i_dev)
> + return;
> +
> + pm_runtime_disable(&pdev->dev);
> + if (!pm_runtime_status_suspended(&pdev->dev))
There is a difference between pm_runtime_status_suspended() and
pm_runtime_suspended(). Are you sure you use the proper call here?
(Please, double check.)
> + i2c_dw_shutdown(i_dev);
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-08 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 20:05 [PATCH v4 0/4] i2c: designware: Improve device disable handling William A. Kennington III
2026-05-07 20:05 ` [PATCH v4 1/4] i2c: designware: Introduce shutdown exported function William A. Kennington III
2026-05-08 8:12 ` Andy Shevchenko
2026-05-08 10:01 ` Andy Shevchenko
2026-05-07 20:05 ` [PATCH v4 2/4] i2c: designware: Convert PCI driver to use shutdown hook William A. Kennington III
2026-05-08 8:15 ` Andy Shevchenko [this message]
2026-05-11 19:55 ` William A. Kennington III
2026-05-07 20:05 ` [PATCH v4 3/4] i2c: designware: Convert platform " William A. Kennington III
2026-05-08 8:15 ` Andy Shevchenko
2026-05-11 19:55 ` William A. Kennington III
2026-05-07 20:05 ` [PATCH v4 4/4] i2c: designware: Handle active target cleanly William A. Kennington III
2026-05-08 10:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2biS8SRkeNtGDC@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox