Re: [PATCH] watchdog: apple: Add "apple,t8103-wdt" compatible

Re: [PATCH] watchdog: apple: Add "apple,t8103-wdt" compatible

[Janne Grunau]

On Wed, Dec 31, 2025 at 06:28:17AM -0800, Guenter Roeck wrote:
> On Wed, Dec 31, 2025 at 01:07:21PM +0100, Janne Grunau wrote:
> > After discussion with the devicetree maintainers we agreed to not extend
> > lists with the generic compatible "apple,wdt" anymore [1]. Use
> > "apple,t8103-wdt" as base compatible as it is the SoC the driver and
> > bindings were written for.
> > 
> > [1]: https://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe81bf@kernel.org/
> > 
> I don't understand the rationake from the reference. This patch will need
> an Ack from a DT maintainer.

Sorry for the late reply, I forgot about this. The corresponding change
to the dt-bindings in commit 5410df1a5a4b ("dt-bindings: watchdog:
apple,wdt: Add t6020-wdt compatible") was acked by Rob and is merged.

Cc-ing DT maintainers, patch still applies unchanged.

Janne

> > Fixes: 4ed224aeaf66 ("watchdog: Add Apple SoC watchdog driver")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Neal Gompa <neal@gompa.dev>
> > Signed-off-by: Janne Grunau <j@jannau.net>
> > ---
> > This is split off from the v1 series adding Apple M2 Pro/Max/Ultra
> > device trees in [2].
> > 
> > 2: https://lore.kernel.org/r/20250828-dt-apple-t6020-v1-0-507ba4c4b98e@jannau.net
> > ---
> >  drivers/watchdog/apple_wdt.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
> > index 66a158f67a712bbed394d660071e02140e66c2e5..6b9b0f9b05cedfd7fc5d0d79ba19ab356dc2a080 100644
> > --- a/drivers/watchdog/apple_wdt.c
> > +++ b/drivers/watchdog/apple_wdt.c
> > @@ -218,6 +218,7 @@ static int apple_wdt_suspend(struct device *dev)
> >  static DEFINE_SIMPLE_DEV_PM_OPS(apple_wdt_pm_ops, apple_wdt_suspend, apple_wdt_resume);
> >  
> >  static const struct of_device_id apple_wdt_of_match[] = {
> > +	{ .compatible = "apple,t8103-wdt" },
> >  	{ .compatible = "apple,wdt" },
> >  	{},
> >  };
> > 
> > ---
> > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> > change-id: 20251231-watchdog-apple-t8103-base-compat-8a623e9831b6
> > 
> > Best regards,
> > -- 
> > Janne Grunau <j@jannau.net>
> > 

Re: [PATCH] watchdog: apple: Add "apple,t8103-wdt" compatible

[Guenter Roeck]

On Wed, Dec 31, 2025 at 01:07:21PM +0100, Janne Grunau wrote:
> After discussion with the devicetree maintainers we agreed to not extend
> lists with the generic compatible "apple,wdt" anymore [1]. Use
> "apple,t8103-wdt" as base compatible as it is the SoC the driver and
> bindings were written for.
> 
> [1]: https://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe81bf@kernel.org/
> 
> Fixes: 4ed224aeaf66 ("watchdog: Add Apple SoC watchdog driver")
> Cc: stable@vger.kernel.org
> Reviewed-by: Neal Gompa <neal@gompa.dev>
> Signed-off-by: Janne Grunau <j@jannau.net>

Applied to my hwmon-next branch.

Thanks,
Guenter

> ---
> This is split off from the v1 series adding Apple M2 Pro/Max/Ultra
> device trees in [2].
> 
> 2: https://lore.kernel.org/r/20250828-dt-apple-t6020-v1-0-507ba4c4b98e@jannau.net
> ---
>  drivers/watchdog/apple_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251231-watchdog-apple-t8103-base-compat-8a623e9831b6
> 
> Best regards,
> 
> diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
> index 66a158f67a712bbed394d660071e02140e66c2e5..6b9b0f9b05cedfd7fc5d0d79ba19ab356dc2a080 100644
> --- a/drivers/watchdog/apple_wdt.c
> +++ b/drivers/watchdog/apple_wdt.c
> @@ -218,6 +218,7 @@ static int apple_wdt_suspend(struct device *dev)
>  static DEFINE_SIMPLE_DEV_PM_OPS(apple_wdt_pm_ops, apple_wdt_suspend, apple_wdt_resume);
>  
>  static const struct of_device_id apple_wdt_of_match[] = {
> +	{ .compatible = "apple,t8103-wdt" },
>  	{ .compatible = "apple,wdt" },
>  	{},
>  };

Re: [PATCH] watchdog: apple: Add "apple,t8103-wdt" compatible

[Guenter Roeck]

On 5/11/26 07:04, Guenter Roeck wrote:
> On Wed, Dec 31, 2025 at 01:07:21PM +0100, Janne Grunau wrote:
>> After discussion with the devicetree maintainers we agreed to not extend
>> lists with the generic compatible "apple,wdt" anymore [1]. Use
>> "apple,t8103-wdt" as base compatible as it is the SoC the driver and
>> bindings were written for.
>>
>> [1]: https://lore.kernel.org/asahi/12ab93b7-1fc2-4ce0-926e-c8141cfe81bf@kernel.org/
>>
>> Fixes: 4ed224aeaf66 ("watchdog: Add Apple SoC watchdog driver")
>> Cc: stable@vger.kernel.org
>> Reviewed-by: Neal Gompa <neal@gompa.dev>
>> Signed-off-by: Janne Grunau <j@jannau.net>
> 
> Applied to my hwmon-next branch.
> 

watchdog-next. Sorry for the confusion.

Guenter

> Thanks,
> Guenter
> 
>> ---
>> This is split off from the v1 series adding Apple M2 Pro/Max/Ultra
>> device trees in [2].
>>
>> 2: https://lore.kernel.org/r/20250828-dt-apple-t6020-v1-0-507ba4c4b98e@jannau.net
>> ---
>>   drivers/watchdog/apple_wdt.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>>
>> ---
>> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
>> change-id: 20251231-watchdog-apple-t8103-base-compat-8a623e9831b6
>>
>> Best regards,
>>
>> diff --git a/drivers/watchdog/apple_wdt.c b/drivers/watchdog/apple_wdt.c
>> index 66a158f67a712bbed394d660071e02140e66c2e5..6b9b0f9b05cedfd7fc5d0d79ba19ab356dc2a080 100644
>> --- a/drivers/watchdog/apple_wdt.c
>> +++ b/drivers/watchdog/apple_wdt.c
>> @@ -218,6 +218,7 @@ static int apple_wdt_suspend(struct device *dev)
>>   static DEFINE_SIMPLE_DEV_PM_OPS(apple_wdt_pm_ops, apple_wdt_suspend, apple_wdt_resume);
>>   
>>   static const struct of_device_id apple_wdt_of_match[] = {
>> +	{ .compatible = "apple,t8103-wdt" },
>>   	{ .compatible = "apple,wdt" },
>>   	{},
>>   };
>