* Re: [PATCH v3 03/10] firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members
[not found] ` <20260420-acpm-tmu-v3-3-3dc8e93f0b26@linaro.org>
@ 2026-05-07 12:00 ` Lee Jones
0 siblings, 0 replies; only message in thread
From: Lee Jones @ 2026-05-07 12:00 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Rafael J. Wysocki, Zhang Rui, Lukasz Luba, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Krzysztof Kozlowski,
Alim Akhtar, Bartlomiej Zolnierkiewicz, Kees Cook,
Gustavo A. R. Silva, Peter Griffin, André Draszik,
Daniel Lezcano, Sylwester Nawrocki, Chanwoo Choi,
Michael Turquette, Stephen Boyd, willmcvicker, jyescas, shin.son,
linux-samsung-soc, linux-kernel, linux-pm, devicetree,
linux-arm-kernel, linux-hardening, linux-clk
On Mon, 20 Apr 2026, Tudor Ambarus wrote:
> Rename the `dvfs_ops` and `pmic_ops` members of `struct acpm_ops` to
> `dvfs` and `pmic` respectively.
>
> Since these members are housed within the `acpm_ops` structure and
> utilize the `acpm_*_ops` types, the `_ops` suffix on the variable names
> creates unnecessary redundancy (e.g., `handle.ops.dvfs_ops`).
>
> This cleanup removes the stuttering, leading to cleaner consumer code.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/clk/samsung/clk-acpm.c | 8 ++++----
> drivers/firmware/samsung/exynos-acpm.c | 4 ++--
> drivers/mfd/sec-acpm.c | 6 +++---
Acked-by: Lee Jones <lee@kernel.org>
> include/linux/firmware/samsung/exynos-acpm-protocol.h | 4 ++--
> 4 files changed, 11 insertions(+), 11 deletions(-)
--
Lee Jones
^ permalink raw reply [flat|nested] only message in thread