Re: [PATCH net-next v3 2/2] net: openvswitch: decouple flow_table from ovs_mutex

[David Laight <david.laight.linux@gmail.com>]

On Thu, 7 May 2026 13:31:24 +0200
Paolo Abeni <pabeni@redhat.com> wrote:

> On 5/5/26 10:42 AM, Adrian Moreno wrote:
..
> > +/* Must be called with flow_table->lock held. */
> >  int ovs_flow_tbl_flush(struct flow_table *flow_table)
> >  {
> >  	struct table_instance *old_ti, *new_ti;
> >  	struct table_instance *old_ufid_ti, *new_ufid_ti;
> >  
> > +	ASSERT_OVS_TBL(flow_table);  
> 
> Minor nit: adding the assert and the comment is redundant. I think the
> assert alone would be better. There are other similar later occurrences.

There is no point adding an ASSERT() for a pointer being NULL.
The NULL pointer dereference does the same job and can be easier to
debug because all the registers are still live.

-- David

> 
> /P
> 
>