From: Saurav Sachidanand <sauravsc@amazon.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Akhil R <akhilrajeev@nvidia.com>,
Kartik Rajput <kkartik@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jon Hunter <jonathanh@nvidia.com>, <linux-i2c@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Saurav Sachidanand <sauravsc@amazon.com>
Subject: [PATCH v2 1/2] i2c: tegra: fix pm_runtime leak on mutex_lock failure
Date: Thu, 7 May 2026 22:11:44 +0000 [thread overview]
Message-ID: <20260507221145.62183-2-sauravsc@amazon.com> (raw)
In-Reply-To: <20260507221145.62183-1-sauravsc@amazon.com>
If tegra_i2c_mutex_lock() fails, the function returns without calling
pm_runtime_put(), leaking the runtime PM reference acquired by the
preceding pm_runtime_get_sync(). This prevents the device from ever
entering runtime suspend.
Add the missing pm_runtime_put() before returning on lock failure.
Fixes: 6077cfd716fb ("i2c: tegra: Add support for SW mutex register")
Signed-off-by: Saurav Sachidanand <sauravsc@amazon.com>
---
drivers/i2c/busses/i2c-tegra.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 9fd5ade774a0b..c24b8de0a9c7b 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1666,8 +1666,10 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
}
ret = tegra_i2c_mutex_lock(i2c_dev);
- if (ret)
+ if (ret) {
+ pm_runtime_put(i2c_dev->dev);
return ret;
+ }
for (i = 0; i < num; i++) {
enum msg_end_type end_type = MSG_END_STOP;
--
2.47.3
next prev parent reply other threads:[~2026-05-07 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 19:53 [PATCH 1/1] i2c: tegra: fix error handling in tegra_i2c_xfer() Saurav Sachidanand
2026-05-07 7:23 ` Jon Hunter
2026-05-07 22:11 ` [PATCH v2 0/2] " Saurav Sachidanand
2026-05-07 22:11 ` Saurav Sachidanand [this message]
2026-05-08 10:24 ` [PATCH v2 1/2] i2c: tegra: fix pm_runtime leak on mutex_lock failure Thierry Reding
2026-05-08 15:13 ` Jon Hunter
2026-05-07 22:11 ` [PATCH v2 2/2] i2c: tegra: make tegra_i2c_mutex_unlock() return void Saurav Sachidanand
2026-05-08 10:24 ` Thierry Reding
2026-05-08 15:14 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507221145.62183-2-sauravsc@amazon.com \
--to=sauravsc@amazon.com \
--cc=akhilrajeev@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=treding@nvidia.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox