The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* kconfirm: patch reporting guidelines?
@ 2026-05-06 17:08 Julian Braha
  2026-05-07  5:10 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Julian Braha @ 2026-05-06 17:08 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel

Hi Greg,


*Question 1: should I acknowledge the kconfirm tool in my patches?

I've received a wide range of feedback as I've been submitting patches
from kconfirm findings. For example, Lorenzo thanked me for
acknowledging the tool when submitting a patch:
https://lore.kernel.org/all/bfdfdb05-77e2-455d-b68d-9da3fd9d1c0d@lucifer.local/

and on the other hand, Alexander asked me not to refer to the tool
until it is moved into the tree:
https://lore.kernel.org/all/3ec20142-09d1-436f-a623-21a2440ef7f0-agordeev@linux.ibm.com/


*Question 2: do bugs in kconfig deserve a Fixes tag?

I've found a few instances of dead default statements, which should not
be dead. Fortunately, these just involve the kunit tests. Nothing
crazy.

I previously sent out this patch for powerpc, which has passed 2
reviewers and 1 tester, and none of them have objected to the Fixes tag:
https://lore.kernel.org/all/20260405161545.161006-1-julianbraha@gmail.com/

and on the other hand, Alexander says that this is "no real issue" and
doesn't deserve a Fixes tag:
https://lore.kernel.org/all/3ec20142-09d1-436f-a623-21a2440ef7f0-agordeev@linux.ibm.com/

- Julian Braha

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kconfirm: patch reporting guidelines?
  2026-05-06 17:08 kconfirm: patch reporting guidelines? Julian Braha
@ 2026-05-07  5:10 ` Greg Kroah-Hartman
  2026-05-07  9:19   ` Julian Braha
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2026-05-07  5:10 UTC (permalink / raw)
  To: Julian Braha; +Cc: linux-kernel

On Wed, May 06, 2026 at 06:08:45PM +0100, Julian Braha wrote:
> Hi Greg,
> 
> 
> *Question 1: should I acknowledge the kconfirm tool in my patches?

What is "kconfirm"?

> I've received a wide range of feedback as I've been submitting patches
> from kconfirm findings. For example, Lorenzo thanked me for
> acknowledging the tool when submitting a patch:
> https://lore.kernel.org/all/bfdfdb05-77e2-455d-b68d-9da3fd9d1c0d@lucifer.local/
> 
> and on the other hand, Alexander asked me not to refer to the tool
> until it is moved into the tree:
> https://lore.kernel.org/all/3ec20142-09d1-436f-a623-21a2440ef7f0-agordeev@linux.ibm.com/

The issue is that you are adding Fixes: tags for something that is not
really a fix.

And each maintainer has their own opinion, but adding a line saying what
tool you are using is a requirement of ours, so this is fine to keep.

> *Question 2: do bugs in kconfig deserve a Fixes tag?

Probably not.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kconfirm: patch reporting guidelines?
  2026-05-07  5:10 ` Greg Kroah-Hartman
@ 2026-05-07  9:19   ` Julian Braha
  2026-05-07 10:06     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Julian Braha @ 2026-05-07  9:19 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel

On 5/7/26 06:10, Greg Kroah-Hartman wrote:
> What is "kconfirm"?

Sorry again, this is becoming a recurring issue for me with lacking
context...
The introduction of kconfirm to the mailing list is here:
https://lore.kernel.org/all/6ec4df6d-1445-48ca-8f54-1d1a83c4716d@gmail.com/

> adding a line saying what
> tool you are using is a requirement of ours, so this is fine to keep.
>
>> *Question 2: do bugs in kconfig deserve a Fixes tag?
>
> Probably not.

Thank you! I will resubmit the existing patches without Fixes tags, and
continue acknowledging the tool.

- Julian Braha

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kconfirm: patch reporting guidelines?
  2026-05-07  9:19   ` Julian Braha
@ 2026-05-07 10:06     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2026-05-07 10:06 UTC (permalink / raw)
  To: Julian Braha; +Cc: linux-kernel

On Thu, May 07, 2026 at 10:19:15AM +0100, Julian Braha wrote:
> On 5/7/26 06:10, Greg Kroah-Hartman wrote:
> > What is "kconfirm"?
> 
> Sorry again, this is becoming a recurring issue for me with lacking
> context...
> The introduction of kconfirm to the mailing list is here:
> https://lore.kernel.org/all/6ec4df6d-1445-48ca-8f54-1d1a83c4716d@gmail.com/

Why not work on getting that merged?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-07 10:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 17:08 kconfirm: patch reporting guidelines? Julian Braha
2026-05-07  5:10 ` Greg Kroah-Hartman
2026-05-07  9:19   ` Julian Braha
2026-05-07 10:06     ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox