The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [RFC PATCH] usb: host: Default CONFIG_USB_XHCI_RCAR to module
@ 2026-05-07 15:47 Prabhakar
  2026-05-07 16:20 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Prabhakar @ 2026-05-07 15:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, Yoshihiro Shimoda, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel, linux-renesas-soc, Prabhakar, Biju Das,
	Fabrizio Castro, Lad Prabhakar

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

On R-Car Gen3 and RZ/G2HMNE SoCs, when CONFIG_USB_XHCI_RCAR is built-in
and the system boots with an NFS root filesystem, the xHCI controller
probes before firmware becomes available. As a result, the firmware
request fails:

  xhci-renesas-hcd ee000000.usb: Direct firmware load for
  r8a779x_usb3_v3.dlmem failed with error -2

Default CONFIG_USB_XHCI_RCAR to module on ARCH_RENESAS so that probing
is deferred until after the root filesystem is mounted, ensuring that
the firmware is accessible.

Configurations explicitly selecting CONFIG_USB_XHCI_RCAR=y are
unaffected.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/usb/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 0a277a07cf70..b70e019cc3ac 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -90,7 +90,7 @@ config USB_XHCI_RCAR
 	tristate "xHCI support for Renesas R-Car SoCs"
 	depends on USB_XHCI_PLATFORM
 	depends on ARCH_RENESAS || COMPILE_TEST
-	default ARCH_RENESAS
+	default m if ARCH_RENESAS
 	help
 	  Say 'Y' to enable the support for the xHCI host controller
 	  found in Renesas R-Car and RZ/G3E alike ARM SoCs.
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH] usb: host: Default CONFIG_USB_XHCI_RCAR to module
  2026-05-07 15:47 [RFC PATCH] usb: host: Default CONFIG_USB_XHCI_RCAR to module Prabhakar
@ 2026-05-07 16:20 ` Greg Kroah-Hartman
  2026-05-07 21:07   ` Lad, Prabhakar
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-05-07 16:20 UTC (permalink / raw)
  To: Prabhakar
  Cc: Geert Uytterhoeven, Yoshihiro Shimoda, linux-usb, linux-kernel,
	linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar

On Thu, May 07, 2026 at 04:47:10PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> On R-Car Gen3 and RZ/G2HMNE SoCs, when CONFIG_USB_XHCI_RCAR is built-in
> and the system boots with an NFS root filesystem, the xHCI controller
> probes before firmware becomes available. As a result, the firmware
> request fails:
> 
>   xhci-renesas-hcd ee000000.usb: Direct firmware load for
>   r8a779x_usb3_v3.dlmem failed with error -2
> 
> Default CONFIG_USB_XHCI_RCAR to module on ARCH_RENESAS so that probing
> is deferred until after the root filesystem is mounted, ensuring that
> the firmware is accessible.
> 
> Configurations explicitly selecting CONFIG_USB_XHCI_RCAR=y are
> unaffected.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 0a277a07cf70..b70e019cc3ac 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -90,7 +90,7 @@ config USB_XHCI_RCAR
>  	tristate "xHCI support for Renesas R-Car SoCs"
>  	depends on USB_XHCI_PLATFORM
>  	depends on ARCH_RENESAS || COMPILE_TEST
> -	default ARCH_RENESAS
> +	default m if ARCH_RENESAS

The module type here depends on your root filesystem.  If you are using
nfs for your root, then you always know you need to properly build stuff
into the kernel for modules that need firmware, this shouldn't be a
default thing as NFS surely isn't a default system type anymore.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH] usb: host: Default CONFIG_USB_XHCI_RCAR to module
  2026-05-07 16:20 ` Greg Kroah-Hartman
@ 2026-05-07 21:07   ` Lad, Prabhakar
  0 siblings, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2026-05-07 21:07 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Geert Uytterhoeven, Yoshihiro Shimoda, linux-usb, linux-kernel,
	linux-renesas-soc, Biju Das, Fabrizio Castro, Lad Prabhakar

Hi Greg,

On Thu, May 7, 2026 at 5:20 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, May 07, 2026 at 04:47:10PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > On R-Car Gen3 and RZ/G2HMNE SoCs, when CONFIG_USB_XHCI_RCAR is built-in
> > and the system boots with an NFS root filesystem, the xHCI controller
> > probes before firmware becomes available. As a result, the firmware
> > request fails:
> >
> >   xhci-renesas-hcd ee000000.usb: Direct firmware load for
> >   r8a779x_usb3_v3.dlmem failed with error -2
> >
> > Default CONFIG_USB_XHCI_RCAR to module on ARCH_RENESAS so that probing
> > is deferred until after the root filesystem is mounted, ensuring that
> > the firmware is accessible.
> >
> > Configurations explicitly selecting CONFIG_USB_XHCI_RCAR=y are
> > unaffected.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  drivers/usb/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 0a277a07cf70..b70e019cc3ac 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -90,7 +90,7 @@ config USB_XHCI_RCAR
> >       tristate "xHCI support for Renesas R-Car SoCs"
> >       depends on USB_XHCI_PLATFORM
> >       depends on ARCH_RENESAS || COMPILE_TEST
> > -     default ARCH_RENESAS
> > +     default m if ARCH_RENESAS
>
> The module type here depends on your root filesystem.  If you are using
> nfs for your root, then you always know you need to properly build stuff
> into the kernel for modules that need firmware, this shouldn't be a
> default thing as NFS surely isn't a default system type anymore.
>
I agree. The module handling depends on the root filesystem setup.
I’ll drop this patch.

Cheers,
Prabhakar

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-07 21:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 15:47 [RFC PATCH] usb: host: Default CONFIG_USB_XHCI_RCAR to module Prabhakar
2026-05-07 16:20 ` Greg Kroah-Hartman
2026-05-07 21:07   ` Lad, Prabhakar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox