The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Albert Esteve <aesteve@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	 Jessica Zhang <jesszhan0024@gmail.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Michael Tretter <m.tretter@pengutronix.de>,
	 Michael Walle <mwalle@kernel.org>,
	 Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Albert Esteve <aesteve@redhat.com>
Subject: [PATCH v2 00/10] drm/panel: Use refcounted allocation for remaining panel drivers
Date: Fri, 08 May 2026 09:04:40 +0200	[thread overview]
Message-ID: <20260508-drm_panel_init_rm-v2-0-0bd4ac429971@redhat.com> (raw)

This series converts 9 remaining panel drivers from the deprecated
devm_kzalloc() + drm_panel_init() pattern to the refcounted
devm_drm_panel_alloc() API. This follows the work by Anusha Srivatsa
who introduced the refcounted panel allocation infrastructure [1] and
converted a first batch of drivers [2] (the last part of a 5 sub-series).

Reasoning:
----------
The old allocation pattern is unsafe: when the panel device is
unbound, devm frees the context struct immediately, but the DRM
device may still hold a reference to the embedded drm_panel through
the panel bridge, leading to a use-after-free. devm_drm_panel_alloc()
wraps the allocation in a kref scheme, so the memory is only freed
when the last reference is dropped.

After this series, there are no remaining callers of drm_panel_init()
under drivers/gpu/drm/panel/, and drm_panel_init() is entirely removed
from the public API.

[1] https://lore.kernel.org/all/20250331-b4-panel-refcounting-v4-0-dad50c60c6c9@redhat.com/
[2] https://lore.kernel.org/all/20250710-b4-driver-convert-last-part-july-v1-0-de73ba81b2f5@redhat.com/

Signed-off-by: Albert Esteve <aesteve@redhat.com>
---
Changes in v2:
- Remove drm_panel_init/alloc precedence mentions in kdocs
- Link to v1: https://lore.kernel.org/r/20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com

---
Albert Esteve (10):
      drm/panel/visionox-g2647fb105: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/samsung-s6e63m0: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/novatek-nt37700f: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/lxd-m9189a: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/ilitek-ili9806e: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/tdo-tl070wsh30: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/sharp-ls043t1le01: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/truly-nt35597: Use refcounted allocation in place of devm_kzalloc()
      drm/panel/startek-kd070fhfid015: Use refcounted allocation in place of devm_kzalloc()
      drm/panel: Make drm_panel_init() static

 drivers/gpu/drm/display/drm_dp_helper.c             |  2 --
 drivers/gpu/drm/drm_panel.c                         |  7 +++----
 drivers/gpu/drm/panel/panel-ilitek-ili9806e-core.c  | 10 +++++-----
 drivers/gpu/drm/panel/panel-lxd-m9189a.c            | 11 ++++++-----
 drivers/gpu/drm/panel/panel-novatek-nt37700f.c      | 11 ++++++-----
 drivers/gpu/drm/panel/panel-samsung-s6e63m0.c       | 14 +++++++-------
 drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c     | 11 ++++++-----
 drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c | 12 ++++++------
 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c        | 14 +++++++-------
 drivers/gpu/drm/panel/panel-truly-nt35597.c         | 10 +++++-----
 drivers/gpu/drm/panel/panel-visionox-g2647fb105.c   | 13 ++++++-------
 include/drm/drm_panel.h                             |  4 ----
 12 files changed, 57 insertions(+), 62 deletions(-)
---
base-commit: 74fe02ce122a6103f207d29fafc8b3a53de6abaf
change-id: 20260506-drm_panel_init_rm-3a4489701f10

Best regards,
-- 
Albert Esteve <aesteve@redhat.com>


             reply	other threads:[~2026-05-08  7:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  7:04 Albert Esteve [this message]
2026-05-08  7:04 ` [PATCH v2 01/10] drm/panel/visionox-g2647fb105: Use refcounted allocation in place of devm_kzalloc() Albert Esteve
2026-05-08  7:04 ` [PATCH v2 02/10] drm/panel/samsung-s6e63m0: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 03/10] drm/panel/novatek-nt37700f: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 04/10] drm/panel/lxd-m9189a: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 05/10] drm/panel/ilitek-ili9806e: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 06/10] drm/panel/tdo-tl070wsh30: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 07/10] drm/panel/sharp-ls043t1le01: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 08/10] drm/panel/truly-nt35597: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 09/10] drm/panel/startek-kd070fhfid015: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 10/10] drm/panel: Make drm_panel_init() static Albert Esteve
2026-05-08  7:29 ` [PATCH v2 00/10] drm/panel: Use refcounted allocation for remaining panel drivers Thomas Zimmermann
2026-05-08 11:28 ` Dmitry Baryshkov
2026-05-11  7:16 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508-drm_panel_init_rm-v2-0-0bd4ac429971@redhat.com \
    --to=aesteve@redhat.com \
    --cc=airlied@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.tretter@pengutronix.de \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox