The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Albert Esteve <aesteve@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	 Jessica Zhang <jesszhan0024@gmail.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Michael Tretter <m.tretter@pengutronix.de>,
	 Michael Walle <mwalle@kernel.org>,
	 Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Albert Esteve <aesteve@redhat.com>
Subject: [PATCH v2 06/10] drm/panel/tdo-tl070wsh30: Use refcounted allocation in place of devm_kzalloc()
Date: Fri, 08 May 2026 09:04:46 +0200	[thread overview]
Message-ID: <20260508-drm_panel_init_rm-v2-6-0bd4ac429971@redhat.com> (raw)
In-Reply-To: <20260508-drm_panel_init_rm-v2-0-0bd4ac429971@redhat.com>

Move to using the new API devm_drm_panel_alloc() to allocate the
panel. In the call to the new API, avoid using explicit type and use
__typeof() for more type safety.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
---
 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
index 227f97f9b136f..13cfe252a838d 100644
--- a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
+++ b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
@@ -162,9 +162,6 @@ static int tdo_tl070wsh30_panel_add(struct tdo_tl070wsh30_panel *tdo_tl070wsh30)
 		return err;
 	}
 
-	drm_panel_init(&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev,
-		       &tdo_tl070wsh30_panel_funcs, DRM_MODE_CONNECTOR_DSI);
-
 	err = drm_panel_of_backlight(&tdo_tl070wsh30->base);
 	if (err)
 		return err;
@@ -183,10 +180,13 @@ static int tdo_tl070wsh30_panel_probe(struct mipi_dsi_device *dsi)
 	dsi->format = MIPI_DSI_FMT_RGB888;
 	dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM;
 
-	tdo_tl070wsh30 = devm_kzalloc(&dsi->dev, sizeof(*tdo_tl070wsh30),
-				    GFP_KERNEL);
-	if (!tdo_tl070wsh30)
-		return -ENOMEM;
+	tdo_tl070wsh30 = devm_drm_panel_alloc(&dsi->dev,
+					      __typeof(*tdo_tl070wsh30), base,
+					      &tdo_tl070wsh30_panel_funcs,
+					      DRM_MODE_CONNECTOR_DSI);
+
+	if (IS_ERR(tdo_tl070wsh30))
+		return PTR_ERR(tdo_tl070wsh30);
 
 	mipi_dsi_set_drvdata(dsi, tdo_tl070wsh30);
 	tdo_tl070wsh30->link = dsi;

-- 
2.53.0


  parent reply	other threads:[~2026-05-08  7:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08  7:04 [PATCH v2 00/10] drm/panel: Use refcounted allocation for remaining panel drivers Albert Esteve
2026-05-08  7:04 ` [PATCH v2 01/10] drm/panel/visionox-g2647fb105: Use refcounted allocation in place of devm_kzalloc() Albert Esteve
2026-05-08  7:04 ` [PATCH v2 02/10] drm/panel/samsung-s6e63m0: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 03/10] drm/panel/novatek-nt37700f: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 04/10] drm/panel/lxd-m9189a: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 05/10] drm/panel/ilitek-ili9806e: " Albert Esteve
2026-05-08  7:04 ` Albert Esteve [this message]
2026-05-08  7:04 ` [PATCH v2 07/10] drm/panel/sharp-ls043t1le01: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 08/10] drm/panel/truly-nt35597: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 09/10] drm/panel/startek-kd070fhfid015: " Albert Esteve
2026-05-08  7:04 ` [PATCH v2 10/10] drm/panel: Make drm_panel_init() static Albert Esteve
2026-05-08  7:29 ` [PATCH v2 00/10] drm/panel: Use refcounted allocation for remaining panel drivers Thomas Zimmermann
2026-05-08 11:28 ` Dmitry Baryshkov
2026-05-11  7:16 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508-drm_panel_init_rm-v2-6-0bd4ac429971@redhat.com \
    --to=aesteve@redhat.com \
    --cc=airlied@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.tretter@pengutronix.de \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox