* Re: [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset
[not found] ` <20260501061146.6e61392d125cf1847d7cc181@linux-foundation.org>
@ 2026-05-08 2:01 ` Frederick Mayle
2026-05-08 19:24 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Frederick Mayle @ 2026-05-08 2:01 UTC (permalink / raw)
To: Andrew Morton
Cc: Matthew Wilcox, android-mm, kernel-team, Jan Kara, linux-fsdevel,
linux-mm, linux-kernel
On Fri, May 1, 2026 at 6:11 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 30 Apr 2026 18:19:07 -0700 Frederick Mayle <fmayle@google.com> wrote:
>
> > Minor cleanup, no behavior change intended.
> >
> > `read_pages` ensures that `ractl->_nr_pages` is zero before it returns,
>
> So it seems, but depending upon this might be a bit fragile?
>
> It would be better to make this a more explicit/formal part of the
> read_pages() contract. kerneldocifying read_pages() would be a
> suitable way.
I agree. I've sent the following patch to document the invariant
https://lore.kernel.org/r/20260508015402.735441-1-fmayle@google.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset
2026-05-08 2:01 ` [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset Frederick Mayle
@ 2026-05-08 19:24 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-05-08 19:24 UTC (permalink / raw)
To: Frederick Mayle
Cc: Matthew Wilcox, android-mm, kernel-team, Jan Kara, linux-fsdevel,
linux-mm, linux-kernel
On Thu, 7 May 2026 19:01:27 -0700 Frederick Mayle <fmayle@google.com> wrote:
> On Fri, May 1, 2026 at 6:11 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Thu, 30 Apr 2026 18:19:07 -0700 Frederick Mayle <fmayle@google.com> wrote:
> >
> > > Minor cleanup, no behavior change intended.
> > >
> > > `read_pages` ensures that `ractl->_nr_pages` is zero before it returns,
> >
> > So it seems, but depending upon this might be a bit fragile?
> >
> > It would be better to make this a more explicit/formal part of the
> > read_pages() contract. kerneldocifying read_pages() would be a
> > suitable way.
>
> I agree. I've sent the following patch to document the invariant
> https://lore.kernel.org/r/20260508015402.735441-1-fmayle@google.com/
Thanks. I suggest you turn both into a single patch and resend when
people have returned and recovered from the conference ;)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-08 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260501011908.3630802-1-fmayle@google.com>
[not found] ` <20260501061146.6e61392d125cf1847d7cc181@linux-foundation.org>
2026-05-08 2:01 ` [PATCH 1/1] mm/readahead: simplify page_cache_ra_unbounded loop counter reset Frederick Mayle
2026-05-08 19:24 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox