* [PATCH RESEND] stm class: remove unnecessary local variable in stm_write
@ 2026-05-08 14:47 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2026-05-08 14:47 UTC (permalink / raw)
To: Alexander Shishkin, Maxime Coquelin, Alexandre Torgue
Cc: Thorsten Blum, linux-stm32, linux-arm-kernel, linux-kernel
The local error variable and the corresponding if check in stm_write()
are unnecessary. Remove them.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/hwtracing/stm/core.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index f48c6a8a0654..edf3d69a84a9 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -602,17 +602,11 @@ static ssize_t notrace
stm_write(struct stm_device *stm, struct stm_output *output,
unsigned int chan, const char *buf, size_t count, struct stm_source_data *source)
{
- int err;
-
/* stm->pdrv is serialized against policy_mutex */
if (!stm->pdrv)
return -ENODEV;
- err = stm->pdrv->write(stm->data, output, chan, buf, count, source);
- if (err < 0)
- return err;
-
- return err;
+ return stm->pdrv->write(stm->data, output, chan, buf, count, source);
}
static ssize_t stm_char_write(struct file *file, const char __user *buf,
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-08 14:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-08 14:47 [PATCH RESEND] stm class: remove unnecessary local variable in stm_write Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox