Re: [PATCH v1 00/10] platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

Re: [PATCH v1 00/10] platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

[Derek J. Clark]

>This draft patch series brings into parity the msi-wmi-platform driver with
>the MSI Center M Windows application for the MSI Claw (all models).
>Unfortunately, MSI Center M and this interface do not have a discovery API,
>necessitating the introduction of a quirk system.
>
>While this patch series is fully functional and tested, there are still
>some issues that need to be addressed:
>  - Armin notes we need to disable fan curve support by default and quirk
>    it as well, as it is not supported on all models. However, the way
>    PWM enable ops work, this makes it a bit difficult, so I would like
>    some suggestions on how to rework this.
>  - It turns out that to fully disable the fan curve, we have to restore
>    the default fan values. This is also what is done on the OEM software.
>    For this, the last patch in the series is used, which is a bit dirty.
>
>Sleep was tested with all values being preserved during S0iX (platform
>profile, fan curve, PL1/PL2), so we do not need suspend/resume hooks, at
>least for the Claw devices.
>
>For PL1/PL2, we use firmware-attributes. So for that I +cc Kurt since if
>his new high level interface is merged beforehand, we can use that instead.
>

Hi Antheas,

It seems this series is stalled for 3 days shy of a year now. I have an
interest in getting this across the finish line. Will you be continuing
development? If not, I will take what you've started here and finish out
the remaining nits, keeping your original attribution of course.

Cheers,
Derek

>Antheas Kapenekakis (8):
>  platform/x86: msi-wmi-platform: Add unlocked msi_wmi_platform_query
>  platform/x86: msi-wmi-platform: Add quirk system
>  platform/x86: msi-wmi-platform: Add platform profile through shift
>    mode
>  platform/x86: msi-wmi-platform: Add PL1/PL2 support via firmware
>    attributes
>  platform/x86: msi-wmi-platform: Add charge_threshold support
>  platform/x86: msi-wmi-platform: Drop excess fans in dual fan devices
>  platform/x86: msi-wmi-platform: Update header text
>  platform/x86: msi-wmi-platform: Restore fan curves on PWM disable and
>    unload
>
>Armin Wolf (2):
>  platform/x86: msi-wmi-platform: Use input buffer for returning result
>  platform/x86: msi-wmi-platform: Add support for fan control
>
> .../wmi/devices/msi-wmi-platform.rst          |   26 +
> drivers/platform/x86/Kconfig                  |    3 +
> drivers/platform/x86/msi-wmi-platform.c       | 1181 ++++++++++++++++-
> 3 files changed, 1156 insertions(+), 54 deletions(-)
>
>
>base-commit: 62b1dcf2e7af3dc2879d1a39bf6823c99486a8c2

Re: [PATCH v1 00/10] platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

[Antheas Kapenekakis]

On Fri, 8 May 2026 at 20:41, Derek J. Clark <derekjohn.clark@gmail.com> wrote:
>
> >This draft patch series brings into parity the msi-wmi-platform driver with
> >the MSI Center M Windows application for the MSI Claw (all models).
> >Unfortunately, MSI Center M and this interface do not have a discovery API,
> >necessitating the introduction of a quirk system.
> >
> >While this patch series is fully functional and tested, there are still
> >some issues that need to be addressed:
> >  - Armin notes we need to disable fan curve support by default and quirk
> >    it as well, as it is not supported on all models. However, the way
> >    PWM enable ops work, this makes it a bit difficult, so I would like
> >    some suggestions on how to rework this.
> >  - It turns out that to fully disable the fan curve, we have to restore
> >    the default fan values. This is also what is done on the OEM software.
> >    For this, the last patch in the series is used, which is a bit dirty.
> >
> >Sleep was tested with all values being preserved during S0iX (platform
> >profile, fan curve, PL1/PL2), so we do not need suspend/resume hooks, at
> >least for the Claw devices.
> >
> >For PL1/PL2, we use firmware-attributes. So for that I +cc Kurt since if
> >his new high level interface is merged beforehand, we can use that instead.
> >
>
> Hi Antheas,
>
> It seems this series is stalled for 3 days shy of a year now. I have an
> interest in getting this across the finish line. Will you be continuing
> development? If not, I will take what you've started here and finish out
> the remaining nits, keeping your original attribution of course.

Hi,
I plan to get back to this after the standby rfc is in a good place.
There are some issues with this series that need resolving, MSI
firmware is a lot more varied and unstable than other OEMs which make
it hard to pin down to a defined ABI.

For V2, we'd need to look into testing into at least some laptops to
verify shift mode behavior

Antheas

> Cheers,
> Derek
>
> >Antheas Kapenekakis (8):
> >  platform/x86: msi-wmi-platform: Add unlocked msi_wmi_platform_query
> >  platform/x86: msi-wmi-platform: Add quirk system
> >  platform/x86: msi-wmi-platform: Add platform profile through shift
> >    mode
> >  platform/x86: msi-wmi-platform: Add PL1/PL2 support via firmware
> >    attributes
> >  platform/x86: msi-wmi-platform: Add charge_threshold support
> >  platform/x86: msi-wmi-platform: Drop excess fans in dual fan devices
> >  platform/x86: msi-wmi-platform: Update header text
> >  platform/x86: msi-wmi-platform: Restore fan curves on PWM disable and
> >    unload
> >
> >Armin Wolf (2):
> >  platform/x86: msi-wmi-platform: Use input buffer for returning result
> >  platform/x86: msi-wmi-platform: Add support for fan control
> >
> > .../wmi/devices/msi-wmi-platform.rst          |   26 +
> > drivers/platform/x86/Kconfig                  |    3 +
> > drivers/platform/x86/msi-wmi-platform.c       | 1181 ++++++++++++++++-
> > 3 files changed, 1156 insertions(+), 54 deletions(-)
> >
> >
> >base-commit: 62b1dcf2e7af3dc2879d1a39bf6823c99486a8c2
>