* [PATCH] hwmon: (tmp102) Change mode to read label property
@ 2026-05-09 11:24 Flaviu Nistor
2026-05-09 11:39 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Flaviu Nistor @ 2026-05-09 11:24 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Flaviu Nistor, linux-hwmon, linux-kernel
Replace of_property_read_string() with the preferred
device_property_read_string() in the probe function to
read the device label property, improving the driver
compatibility since this method is not limited to
Device Tree only.
Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
drivers/hwmon/tmp102.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index 3aa1a3fbeaa9..a89cc49798f5 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -313,7 +313,7 @@ static int tmp102_probe(struct i2c_client *client)
if (!tmp102)
return -ENOMEM;
- of_property_read_string(dev->of_node, "label", &tmp102->label);
+ device_property_read_string(dev, "label", &tmp102->label);
i2c_set_clientdata(client, tmp102);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (tmp102) Change mode to read label property
2026-05-09 11:24 [PATCH] hwmon: (tmp102) Change mode to read label property Flaviu Nistor
@ 2026-05-09 11:39 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2026-05-09 11:39 UTC (permalink / raw)
To: Flaviu Nistor; +Cc: linux-hwmon, linux-kernel
On 5/9/26 04:24, Flaviu Nistor wrote:
> Replace of_property_read_string() with the preferred
> device_property_read_string() in the probe function to
> read the device label property, improving the driver
> compatibility since this method is not limited to
> Device Tree only.
>
The subject of this patch is completely off ...
"change mode" - what does this even mean ?
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> ---
> drivers/hwmon/tmp102.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
> index 3aa1a3fbeaa9..a89cc49798f5 100644
> --- a/drivers/hwmon/tmp102.c
> +++ b/drivers/hwmon/tmp102.c
> @@ -313,7 +313,7 @@ static int tmp102_probe(struct i2c_client *client)
> if (!tmp102)
> return -ENOMEM;
>
> - of_property_read_string(dev->of_node, "label", &tmp102->label);
> + device_property_read_string(dev, "label", &tmp102->label);
>
Changing this also requires changing include files.
Instead of including linux/of.h, you'll need to include
linux/mod_devicetable.h and linux/property.h.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-09 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-09 11:24 [PATCH] hwmon: (tmp102) Change mode to read label property Flaviu Nistor
2026-05-09 11:39 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox