Re: [net-next PATCH v2 1/8] net: dsa: realtek: rtl8365mb: use ERR_PTR

Re: [net-next PATCH v2 1/8] net: dsa: realtek: rtl8365mb: use ERR_PTR

[Linus Walleij]

On Sun, May 3, 2026 at 8:18 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> Convert numeric error codes into human-readable strings by
> using %pe together with ERR_PTR() in dev_err() messages.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 2/8] net: dsa: realtek: rtl8365mb: use dsa helpers for port iteration

[Linus Walleij]

On Sun, May 3, 2026 at 8:18 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> Use dsa_switch_for_each_*() whenever possible.
>
> For port setup(), a new blocking setup phase was added for all ports,
> including unused ones, before the user and CPU port setup.
>
> CPU isolation now includes all user ports as traffic was being blocked in
> some scenarios (suggested by Abdulkader Alrezej).
>
> Suggested-by: Abdulkader Alrezej <abdulkader.alrezej@gmail.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 5/8] net: dsa: realtek: rtl8365mb: add VLAN support

[Linus Walleij]

On Sun, May 3, 2026 at 8:19 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Realtek RTL8365MB switches (a.k.a. RTL8367C family) use two different
> structures for VLANs:
>
> - VLAN4K: A full table with 4096 entries defining port membership and
>   tagging.
> - VLANMC: A smaller table with 32 entries used primarily for PVID
>   assignment.
>
> In this hardware, a port's PVID must point to an index in the VLANMC
> table rather than a VID directly. Since the VLANMC table is limited to
> 32 entries, the driver implements a dynamic allocation scheme to
> maximize resource usage:
>
> - VLAN4K is treated by the driver as the source of truth for membership.
> - A VLANMC entry is only allocated when a port is configured to use a
>   specific VID as its PVID.
> - VLANMC entries are deleted when no longer needed as a PVID by any port.
>
> Although VLANMC has a members field, the switch only checks membership
> in the VLAN4K table. However, when a corresponding VLAN entry also exists
> in VLANMC, this driver keeps both membership configurations in sync.
>
> VLANMC index 0, although a valid entry, is reserved in this driver as a
> neutral PVID value for ports not using a specific PVID.
>
> In the subsequent RTL8367D switch family, VLANMC table was
> removed and PVID assignment was delegated to a dedicated set of
> registers.
>
> All ports start isolated, forwarding exclusively to CPU ports, and
> with VLAN transparent, ignoring VLAN membership. Once a member in a
> bridge, the port isolation is expanded to include the bridge members.
> When that bridge enables VLAN filtering, the VLAN transparent feature is
> disabled, letting the switch filter based on VLAN setup.
>
> The use of FIELD_PREP for reconstructing LO/HI values was suggested by
> Yury Norov.
>
> Fix for vlan_setup and vlan_filtering was suggested by Abdulkader
> Alrezej.
>
> Suggested-by: Yury Norov <ynorov@nvidia.com>
> Suggested-by: Abdulkader Alrezej <abdulkader.alrezej@gmail.com>
> Co-developed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Allright go ahead like this. Mental not to move the RTL8366RB
VLAN handling down into the driver.
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 6/8] net: dsa: realtek: rtl8365mb: add port_bridge_{join,leave}

[Linus Walleij]

On Sun, May 3, 2026 at 8:19 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Implement hardware offloading of bridge functionality. This is achieved
> by using the per-port isolation registers, which contain a forwarding
> port mask. The switch will refuse to forward packets ingressed on a
> given port to a port which is not in its forwarding mask.
>
> For each bridge that is offloaded, use the DSA-provided bridge number
> for the Extended Filtering ID (EFID). When using Independent VLAN
> Learning (IVL), the forwarding database is keyed with the tuple
> {VID, MAC, EFID}. There are 8 EFIDs available (0~7), but we reserve the
> default EFID 0 for standalone ports where learning is disabled. This
> fits nicely because DSA indexes the bridge number starting from 1.
>
> Because of the limited number of EFIDs, we have to set the
> max_num_bridges property of our switch to 7: we can't offload more than
> that or we will fail to offer IVL as at least two bridges would end up
> having to share an EFID.
>
> Co-developed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Sweet, exactly like this! Good work.
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 7/8] net: dsa: realtek: rtl8365mb: add FDB support

[Linus Walleij]

On Sun, May 3, 2026 at 8:19 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Implement support for FDB and MDB management for the RTL8365MB series
> switches.
>
> The hardware supports IVL by keying the forwarding database with the
> {VID, MAC, EFID} tuple.  The Extended Filtering ID (EFID) is 3 bits
> wide, providing 8 unique filtering domains. This driver reserves EFID 0
> for standalone ports, effectively limiting the hardware offload to a
> maximum of 7 bridges.
>
> Introduce a mutex lock (l2_lock) to protect concurrent L2 table updates.
>
> Add support for forwarding database operations, including unicast and
> multicast entry handling as well as fast aging support.
>
> Co-developed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Excellent, thanks!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 7/8] net: dsa: realtek: rtl8365mb: add FDB support

[Jakub Kicinski]

On Sun, 03 May 2026 03:18:27 -0300 Luiz Angelo Daros de Luca wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> Implement support for FDB and MDB management for the RTL8365MB series
> switches.
> 
> The hardware supports IVL by keying the forwarding database with the
> {VID, MAC, EFID} tuple.  The Extended Filtering ID (EFID) is 3 bits
> wide, providing 8 unique filtering domains. This driver reserves EFID 0
> for standalone ports, effectively limiting the hardware offload to a
> maximum of 7 bridges.
> 
> Introduce a mutex lock (l2_lock) to protect concurrent L2 table updates.
> 
> Add support for forwarding database operations, including unicast and
> multicast entry handling as well as fast aging support.

Warning: ../drivers/net/dsa/realtek/rtl8365mb_l2.c:243 function parameter 'entry' not described in 'rtl8365mb_l2_get_next_uc'
Warning: ../drivers/net/dsa/realtek/rtl8365mb_l2.c:243 function parameter 'entry' not described in 'rtl8365mb_l2_get_next_uc'
-- 
pw-bot: cr

Re: [net-next PATCH v2 7/8] net: dsa: realtek: rtl8365mb: add FDB support

[Luiz Angelo Daros de Luca]

> Warning: ../drivers/net/dsa/realtek/rtl8365mb_l2.c:243 function parameter 'entry' not described in 'rtl8365mb_l2_get_next_uc'
> Warning: ../drivers/net/dsa/realtek/rtl8365mb_l2.c:243 function parameter 'entry' not described in 'rtl8365mb_l2_get_next_uc'

Thanks Jakub, sorry for that. I missed the kernel-doc check before submitting.

Regards,

Luiz

Re: [net-next PATCH v2 8/8] net: dsa: realtek: rtl8365mb: add bridge port flags

[Linus Walleij]

On Sun, May 3, 2026 at 8:19 AM Luiz Angelo Daros de Luca
<luizluca@gmail.com> wrote:

> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Implement support for bridge port flags to control learning and flooding
> behavior. This patch maps hardware functionalities to the following
> bridge flags:
>
> - BR_LEARNING
> - BR_FLOOD
> - BR_MCAST_FLOOD
> - BR_BCAST_FLOOD
>
> By default, all flooding types are enabled during port setup to ensure
> standard bridge behavior.
>
> Co-developed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Excellent again, thanks.
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [net-next PATCH v2 8/8] net: dsa: realtek: rtl8365mb: add bridge port flags

[Luiz Angelo Daros de Luca]

> Excellent again, thanks.

Thank you, Linus. The code does look nicer. I hope it will ease our
task of making these Realtek switches feature-complete.

Regards,

Luiz

Re: [net-next PATCH v2 4/8] net: dsa: realtek: rtl8365mb: add table lookup interface

[Jakub Kicinski]

On Sun, 03 May 2026 03:18:24 -0300 Luiz Angelo Daros de Luca wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> Add a generic table lookup interface to centralize access to
> the RTL8365MB internal tables.
> 
> This interface abstracts the low-level table access logic and
> will be used by subsequent commits to implement FDB and VLAN
> operations.

kdoc says:

Warning: drivers/net/dsa/realtek/rtl8365mb_table.h:32 enum rtl8365mb_table { RTL8365MB_TABLE_ACL_RULE = 1, RTL8365MB_TABLE_ACL_ACTION = 2, RTL8365MB_TABLE_CVLAN = 3, RTL8365MB_TABLE_L2 = 4, RTL8365MB_TABLE_IGMP_GROUP = 5, }; error: Cannot parse struct or union!
Warning: drivers/net/dsa/realtek/rtl8365mb_table.h:130 No description found for return value of 'rtl8365mb_table_query'
Warning: drivers/net/dsa/realtek/rtl8365mb_table.h:130 No description found for return value of 'rtl8365mb_table_query'

Re: [net-next PATCH v2 4/8] net: dsa: realtek: rtl8365mb: add table lookup interface

[Jakub Kicinski]

On Sun, 03 May 2026 03:18:24 -0300 Luiz Angelo Daros de Luca wrote:
> +int rtl8365mb_table_query(struct realtek_priv *priv,
> +			  enum rtl8365mb_table table,
> +			  enum rtl8365mb_table_op op, u16 *addr,
> +			  enum rtl8365mb_table_l2_method method,
> +			  u16 port, u16 *data, size_t size)
> +{
> +	bool addr_as_input = true;
> +	bool write_data = false;
> +	int ret = 0;
> +	u32 cmd;
> +	u32 val;
> +	u32 hit;
> +
> +	if (!addr) {
> +		dev_err(priv->dev, "%s: addr is NULL\n", __func__);
> +		return -EINVAL;
> +	}
> +
> +	if (!data) {
> +		dev_err(priv->dev, "%s: data is NULL\n", __func__);
> +		return -EINVAL;
> +	}
> +
> +	if (size > RTL8365MB_TABLE_ENTRY_MAX_SIZE) {
> +		dev_err(priv->dev, "%s: size too big: %zu\n", __func__, size);
> +		return -E2BIG;
> +	}
> +
> +	if (size == 0) {
> +		dev_err(priv->dev, "%s: size is 0\n", __func__);
> +		return -EINVAL;
> +	}

Defensive checks are discouraged in the kernel. AI will make short work
of finding such trivial violations.

Re: [net-next PATCH v2 4/8] net: dsa: realtek: rtl8365mb: add table lookup interface

[Luiz Angelo Daros de Luca]

> Defensive checks are discouraged in the kernel. AI will make short work
> of finding such trivial violations.

Sure. I removed this and other cases. I hope it is fine now. I'll soon
send v3 with the fixes.

Regards,

Luiz

Re: [net-next PATCH v2 0/8] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support

[Simon Horman]

On Sun, May 03, 2026 at 03:18:20AM -0300, Luiz Angelo Daros de Luca wrote:
> This series introduces bridge offloading, FDB management, and VLAN support
> for the Realtek rtl8365mb DSA switch driver. The primary goal is to
> enable hardware frame forwarding between bridge ports, reducing CPU
> overhead and providing advanced features like VLAN and FDB isolation.
> 
> Some of these patches are based on original work by Alvin Šipraga,
> subsequently adapted and updated for the current net-next state.

Hi,

There is somewhat overlapping AI-generated review of this patchset
available at https://netdev-ai.bots.linux.dev/sashiko/ and
https://sashiko.dev/

I would appreciate it if you could look over that and address any issues
which represent new bugs or regressions. While I think that, in general,
any pre-existing problems that are flagged can be left as possible
follow-up.

Re: [net-next PATCH v2 0/8] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support

[Luiz Angelo Daros de Luca]

Hi Simon,

> There is somewhat overlapping AI-generated review of this patchset
> available at https://netdev-ai.bots.linux.dev/sashiko/ and
> https://sashiko.dev/
>
> I would appreciate it if you could look over that and address any issues
> which represent new bugs or regressions. While I think that, in general,
> any pre-existing problems that are flagged can be left as possible
> follow-up.

Thanks for the suggestion. However, it will take me some time to fix
all the issues. Most of them are real.

Regards,

Luiz