Re: MAINTAINERS: Add self for the 3c509 network driver

Re: MAINTAINERS: Add self for the 3c509 network driver

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 27 Apr 2026 11:23:17 +0100 (BST) you wrote:
> It appears there's a need for a maintainer for the 3Com EtherLink III
> family of Ethernet network adapters.  There is documentation available
> and the driver is very mature so the task ought to be of little hassle,
> so I think I should be able to squeeze in any issues to be addressed.
> 
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> 
> [...]

Here is the summary with links:
  - MAINTAINERS: Add self for the 3c509 network driver
    https://git.kernel.org/netdev/net/c/e539acf9f9c2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: MAINTAINERS: Add self for the 3c509 network driver

[Ethan Nelson-Moore]

> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
[...]
>   - MAINTAINERS: Add self for the 3c509 network driver

Hi, Jakub,

Did you forget to revert the driver removal, or have you just not gotten
around to it yet?

Ethan

Re: MAINTAINERS: Add self for the 3c509 network driver

[Maciej W. Rozycki]

On Sat, 9 May 2026, Ethan Nelson-Moore wrote:

> > This patch was applied to netdev/net.git (main)
> > by Jakub Kicinski <kuba@kernel.org>:
> [...]
> >   - MAINTAINERS: Add self for the 3c509 network driver
> 
> Hi, Jakub,
> 
> Did you forget to revert the driver removal, or have you just not gotten
> around to it yet?

 Thanks for the heads-up.  I can see the removal was fast-tracked to 
Linus; I didn't expect that, waiting a couple of weeks for people to speak 
out wouldn't have hurt.  Now `git revert 91f3a27ae9f6' is in order.  
Shall I post the output from that, or what is the expected way to handle 
this situation?

  Maciej

Re: MAINTAINERS: Add self for the 3c509 network driver

[Jakub Kicinski]

On Sun, 10 May 2026 02:57:15 +0100 (BST) Maciej W. Rozycki wrote:
> On Sat, 9 May 2026, Ethan Nelson-Moore wrote:
> > > This patch was applied to netdev/net.git (main)
> > > by Jakub Kicinski <kuba@kernel.org>:  
> > >   - MAINTAINERS: Add self for the 3c509 network driver  
> > 
> > Hi, Jakub,
> > 
> > Did you forget to revert the driver removal, or have you just not gotten
> > around to it yet?  
> 
>  Thanks for the heads-up.  I can see the removal was fast-tracked to 
> Linus; I didn't expect that, waiting a couple of weeks for people to speak 
> out wouldn't have hurt.  Now `git revert 91f3a27ae9f6' is in order.  
> Shall I post the output from that, or what is the expected way to handle 
> this situation?

Sorry, must have missed it or forgotten.
Could you point me to the report of these driver being used?

Re: MAINTAINERS: Add self for the 3c509 network driver

[Jakub Kicinski]

On Sat,  9 May 2026 16:05:20 -0700 Ethan Nelson-Moore wrote:
> > This patch was applied to netdev/net.git (main)
> > by Jakub Kicinski <kuba@kernel.org>:  
> [...]
> >   - MAINTAINERS: Add self for the 3c509 network driver  
> 
> Did you forget to revert the driver removal, or have you just not gotten
> around to it yet?

Heh, I only checked this file isn't already covered.
Did not expect someone could send a patch for a driver that doesn't
exist. 

Re: MAINTAINERS: Add self for the 3c509 network driver

[Ethan Nelson-Moore]

On Sun, May 10, 2026 at 8:58 AM Jakub Kicinski <kuba@kernel.org> wrote:
> Sorry, must have missed it or forgotten.
> Could you point me to the report of these driver being used?

Here:
https://lore.kernel.org/all/alpine.DEB.2.21.2604240004280.28583@angie.orcam.me.uk/

Re: MAINTAINERS: Add self for the 3c509 network driver

[Jakub Kicinski]

On Sun, 10 May 2026 14:44:16 -0700 Ethan Nelson-Moore wrote:
> On Sun, May 10, 2026 at 8:58 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > Sorry, must have missed it or forgotten.
> > Could you point me to the report of these driver being used?  
> 
> Here:
> https://lore.kernel.org/all/alpine.DEB.2.21.2604240004280.28583@angie.orcam.me.uk/

Maciej, what's the relevance of your machine in the lab?
Does the platform or any component that you test on this
platform have actual users?

If the answer is no / unsure please fix the driver up to
follow modern coding standards and submit the patch.

Re: MAINTAINERS: Add self for the 3c509 network driver

[Maciej W. Rozycki]

On Mon, 11 May 2026, Jakub Kicinski wrote:

> > > Sorry, must have missed it or forgotten.
> > > Could you point me to the report of these driver being used?  
> > 
> > Here:
> > https://lore.kernel.org/all/alpine.DEB.2.21.2604240004280.28583@angie.orcam.me.uk/
> 
> Maciej, what's the relevance of your machine in the lab?

 It's one of my test machines for the defxx driver, specifically the EISA 
binding.  The Ethernet link served by the 3c509 driver is for Internet 
access, FDDI is intranet.

> Does the platform or any component that you test on this
> platform have actual users?

 I believe the defxx driver does, yes; unsure about the EISA binding.

> If the answer is no / unsure please fix the driver up to
> follow modern coding standards and submit the patch.

 I don't mind updating for our coding standards, though such a change 
might be considered just irritating noise that interferes with `git blame' 
(though with the removal of the code upstream, this got broken already 
anyway).  NB it's the reason why I have hesitated to reformat the defxx 
driver for decades now, which obviously has much more serious issues here 
such as the assumption of 4-character tabs.

 I think the re-addition needs to be done in two stages, first being a 
plain revert so that no code change comes unrecorded in git, followed by 
the actual formatting cleanup.  Sadly this won't fix `git blame', but at 
least the diff will be empty between the repo states as at respectively 
the removal and the re-addition.

 Does it answer your questions and seem like a reasonable course of 
action?

  Maciej

Re: MAINTAINERS: Add self for the 3c509 network driver

[Jakub Kicinski]

On Tue, 12 May 2026 11:26:37 +0100 (BST) Maciej W. Rozycki wrote:
> On Mon, 11 May 2026, Jakub Kicinski wrote:
> > > Here:
> > > https://lore.kernel.org/all/alpine.DEB.2.21.2604240004280.28583@angie.orcam.me.uk/  
> > 
> > Maciej, what's the relevance of your machine in the lab?  
> 
>  It's one of my test machines for the defxx driver, specifically the EISA 
> binding.  The Ethernet link served by the 3c509 driver is for Internet 
> access, FDDI is intranet.
> 
> > Does the platform or any component that you test on this
> > platform have actual users?  
> 
>  I believe the defxx driver does, yes; unsure about the EISA binding.
> 
> > If the answer is no / unsure please fix the driver up to
> > follow modern coding standards and submit the patch.  
> 
>  I don't mind updating for our coding standards, though such a change 
> might be considered just irritating noise that interferes with `git blame' 
> (though with the removal of the code upstream, this got broken already 
> anyway).  NB it's the reason why I have hesitated to reformat the defxx 
> driver for decades now, which obviously has much more serious issues here 
> such as the assumption of 4-character tabs.
> 
>  I think the re-addition needs to be done in two stages, first being a 
> plain revert so that no code change comes unrecorded in git, followed by 
> the actual formatting cleanup.  Sadly this won't fix `git blame', but at 
> least the diff will be empty between the repo states as at respectively 
> the removal and the re-addition.

Right, since it was already removed the git blame is going to point
to the re-addition. Hence it's an opportunity for a cleanup.

>  Does it answer your questions and seem like a reasonable course of 
> action?

Sounds fine, I'd squash them, but as long as the patches come in one
series - either way works!