The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v3] hwmon: (tmp102) Use device_property_read_string API
@ 2026-05-10  9:25 Flaviu Nistor
  2026-05-10 15:36 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Flaviu Nistor @ 2026-05-10  9:25 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Flaviu Nistor, linux-hwmon, linux-kernel

Replace of_property_read_string() with the preferded
device_property_read_string() in the probe function to
read the device label property, improving the driver
compatibility since this method is not limited to
Device Tree only.

Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
Changes in v3:
- Remove of_match_ptr() as identified in:
https://sashiko.dev/#/patchset/20260509112417.51164-1-flaviu.nistor@gmail.com?part=1
- Link to v2: https://lore.kernel.org/all/20260509121511.60601-1-flaviu.nistor@gmail.com/
Changes in v2:
- Add/remove include files suggested by Guenter Roeck.
- Link to v1: https://lore.kernel.org/all/20260509112417.51164-1-flaviu.nistor@gmail.com/

 drivers/hwmon/tmp102.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
index 3aa1a3fbeaa9..055ee7fe6351 100644
--- a/drivers/hwmon/tmp102.c
+++ b/drivers/hwmon/tmp102.c
@@ -15,7 +15,8 @@
 #include <linux/jiffies.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
-#include <linux/of.h>
+#include <linux/mod_devicetable.h>
+#include <linux/property.h>
 
 #define	DRIVER_NAME "tmp102"
 
@@ -313,7 +314,7 @@ static int tmp102_probe(struct i2c_client *client)
 	if (!tmp102)
 		return -ENOMEM;
 
-	of_property_read_string(dev->of_node, "label", &tmp102->label);
+	device_property_read_string(dev, "label", &tmp102->label);
 
 	i2c_set_clientdata(client, tmp102);
 
@@ -408,7 +409,7 @@ MODULE_DEVICE_TABLE(of, tmp102_of_match);
 
 static struct i2c_driver tmp102_driver = {
 	.driver.name	= DRIVER_NAME,
-	.driver.of_match_table = of_match_ptr(tmp102_of_match),
+	.driver.of_match_table = tmp102_of_match,
 	.driver.pm	= pm_sleep_ptr(&tmp102_dev_pm_ops),
 	.probe		= tmp102_probe,
 	.id_table	= tmp102_id,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-10 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-10  9:25 [PATCH v3] hwmon: (tmp102) Use device_property_read_string API Flaviu Nistor
2026-05-10 15:36 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox