The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Pramod Maurya <pramod.nexgen@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	nikolayof23@gmail.com, Pramod Maurya <pramod.nexgen@gmail.com>
Subject: [PATCH v2 4/4] staging: rtl8723bs: Enclose CHAN_ARG macro body in parentheses
Date: Sun, 10 May 2026 13:52:07 -0400	[thread overview]
Message-ID: <20260510175207.563378-5-pramod.nexgen@gmail.com> (raw)
In-Reply-To: <20260510175207.563378-1-pramod.nexgen@gmail.com>

Wrap the macro expansion in outer parentheses to prevent operator
precedence issues when the macro is used in expressions.

Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
---
 drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h
index beee37041eeb..d1167d9ea846 100644
--- a/drivers/staging/rtl8723bs/include/ieee80211.h
+++ b/drivers/staging/rtl8723bs/include/ieee80211.h
@@ -639,7 +639,7 @@ struct rtw_ieee80211_channel {
 	/*"orig_mpwr:%d\n"*/
 
 #define CHAN_ARG(channel) \
-	/*(channel)->band*/ \
+	(/*(channel)->band*/ \
 	/*, (channel)->center_freq*/ \
 	(channel)->hw_value \
 	, (channel)->flags \
@@ -649,7 +649,7 @@ struct rtw_ieee80211_channel {
 	/*, (channel)->beacon_found*/ \
 	/*, (channel)->orig_flags*/ \
 	/*, (channel)->orig_mag*/ \
-	/*, (channel)->orig_mpwr*/ \
+	/*, (channel)->orig_mpwr*/)
 
 /* Parsed Information Elements */
 struct rtw_ieee802_11_elems {
-- 
2.52.0


  parent reply	other threads:[~2026-05-10 17:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 17:52 [PATCH v2 0/4] staging: rtl8723bs: Fix coding style in ieee80211.h Pramod Maurya
2026-05-10 17:52 ` [PATCH v2 1/4] staging: rtl8723bs: Replace __attribute__((packed)) with __packed " Pramod Maurya
2026-05-10 17:52 ` [PATCH v2 2/4] staging: rtl8723bs: Fix comparison style in IS_CCK_RATE and IS_OFDM_RATE macros Pramod Maurya
2026-05-11  3:48   ` Nikolay Kulikov
2026-05-11  8:11   ` Greg KH
2026-05-10 17:52 ` [PATCH v2 3/4] staging: rtl8723bs: Fix block comment style in ieee80211.h Pramod Maurya
2026-05-10 17:52 ` Pramod Maurya [this message]
2026-05-10 19:58   ` [PATCH v2 4/4] staging: rtl8723bs: Enclose CHAN_ARG macro body in parentheses Nikolay Kulikov
2026-05-11  8:12   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260510175207.563378-5-pramod.nexgen@gmail.com \
    --to=pramod.nexgen@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nikolayof23@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox