From: Greg KH <gregkh@linuxfoundation.org>
To: Pramod Maurya <pramod.nexgen@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
jacobsfeder@gmail.com, devicetree@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: misc: Add binding for Xilinx AXI-Stream FIFO
Date: Sun, 10 May 2026 18:07:01 +0200 [thread overview]
Message-ID: <2026051050-marathon-fragrant-edbf@gregkh> (raw)
In-Reply-To: <20260510084458.73685-1-pramod.nexgen@gmail.com>
On Sun, May 10, 2026 at 04:44:57AM -0400, Pramod Maurya wrote:
> Add a YAML schema for the Xilinx AXI-Stream FIFO IP core (PG080).
> The binding documents the three supported compatible strings and all
> vendor-specific properties that the axis-fifo driver reads from the
> device tree.
>
> This resolves the following checkpatch.pl warnings in
> drivers/staging/axis-fifo/axis-fifo.c:
> WARNING: DT compatible string "xlnx,axi-fifo-mm-s-4.1" appears un-documented
> WARNING: DT compatible string "xlnx,axi-fifo-mm-s-4.2" appears un-documented
> WARNING: DT compatible string "xlnx,axi-fifo-mm-s-4.3" appears un-documented
>
> Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
> ---
> Changes in v2:
> - Delete drivers/staging/axis-fifo/axis-fifo.txt as part of the
> conversion (was missing from v1)
> - Add all Vivado-generated properties to the schema so that real
> hardware DT nodes pass validation with additionalProperties: false
> - Update example to match a realistic Vivado-generated DT node
> including all properties
>
> .../bindings/misc/xlnx,axi-fifo-mm-s.yaml | 265 ++++++++++++++++++
> MAINTAINERS | 6 +
> drivers/staging/axis-fifo/axis-fifo.txt | 96 -------
> 3 files changed, 271 insertions(+), 96 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
No, staging drivers need to be self-contained. When/if the axis-fifo
driver moves out of drivers/staging/ this can happen, but not until
then.
You can convert this to yaml in-place if you want, AND you can test that
the conversion is correct. Do you have this hardware to test this with?
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-10 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 8:44 [PATCH v2] dt-bindings: misc: Add binding for Xilinx AXI-Stream FIFO Pramod Maurya
2026-05-10 16:07 ` Greg KH [this message]
2026-05-11 16:18 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051050-marathon-fragrant-edbf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacobsfeder@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pramod.nexgen@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox