The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: replace msleep with usleep_range for short delays
@ 2026-05-09  8:07 Sridhar Arra
  2026-05-11  8:06 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Sridhar Arra @ 2026-05-09  8:07 UTC (permalink / raw)
  To: gregkh; +Cc: error27, linux-staging, linux-kernel, Sridhar Arra

The checkpatch.pl tool warns that msleep() for values less than 20ms
can be inaccurate. This patch converts the 10ms msleep to
usleep_range(10000, 11000) to provide more precise timing using
high-resolution timers.

Signed-off-by: Sridhar Arra <sridhar.arra.dev@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 5f00fe282d1b..d66f17076818 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5834,7 +5834,8 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsigned char *pbuf)
 		return H2C_SUCCESS;
 
 	if ((pstapriv->tim_bitmap & BIT(0)) && (psta_bmc->sleepq_len > 0)) {
-		msleep(10);/*  10ms, ATIM(HIQ) Windows */
+		/* 10ms - 11ms, ATIM(HIQ) Windows */
+		usleep_range(10000, 11000);
 
 		/* spin_lock_bh(&psta_bmc->sleep_q.lock); */
 		spin_lock_bh(&pxmitpriv->lock);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range for short delays
  2026-05-09  8:07 [PATCH] staging: rtl8723bs: replace msleep with usleep_range for short delays Sridhar Arra
@ 2026-05-11  8:06 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-05-11  8:06 UTC (permalink / raw)
  To: Sridhar Arra; +Cc: error27, linux-staging, linux-kernel

On Sat, May 09, 2026 at 01:37:27PM +0530, Sridhar Arra wrote:
> The checkpatch.pl tool warns that msleep() for values less than 20ms
> can be inaccurate. This patch converts the 10ms msleep to
> usleep_range(10000, 11000) to provide more precise timing using
> high-resolution timers.
> 
> Signed-off-by: Sridhar Arra <sridhar.arra.dev@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 5f00fe282d1b..d66f17076818 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5834,7 +5834,8 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsigned char *pbuf)
>  		return H2C_SUCCESS;
>  
>  	if ((pstapriv->tim_bitmap & BIT(0)) && (psta_bmc->sleepq_len > 0)) {
> -		msleep(10);/*  10ms, ATIM(HIQ) Windows */
> +		/* 10ms - 11ms, ATIM(HIQ) Windows */
> +		usleep_range(10000, 11000);
>  
>  		/* spin_lock_bh(&psta_bmc->sleep_q.lock); */
>  		spin_lock_bh(&pxmitpriv->lock);
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You sent a patch that has been sent multiple times in the past few
  days, and is identical to ones that has been recently rejected.
  Please always look at the mailing list traffic to determine if you are
  duplicating other people's work.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-11  8:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-09  8:07 [PATCH] staging: rtl8723bs: replace msleep with usleep_range for short delays Sridhar Arra
2026-05-11  8:06 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox