* [PATCH] docs: reporting-issues: clarify advice wording
@ 2026-05-12 15:04 Chen-Shi-Hong
2026-05-13 8:08 ` Thorsten Leemhuis
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Shi-Hong @ 2026-05-12 15:04 UTC (permalink / raw)
To: linux; +Cc: corbet, skhan, linux-doc, linux-kernel, Chen-Shi-Hong
A previous change replaced "these advices" with "this advice", but that
wording can be read too narrowly and may seem to refer only to a single
recommendation.
Use "all of this advice" instead to make it clearer that the sentence
refers to the broader set of recommendations in the paragraph.
Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
---
Documentation/admin-guide/reporting-issues.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
index 731865b5e8ff..87dd874fffcf 100644
--- a/Documentation/admin-guide/reporting-issues.rst
+++ b/Documentation/admin-guide/reporting-issues.rst
@@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
situations; during the merge window that actually might be even the best
approach, but in that development phase it can be an even better idea to
suspend your efforts for a few days anyway. Whatever version you choose,
- ideally use a 'vanilla' build. Ignoring this advice will dramatically
+ ideally use a 'vanilla' build. Ignoring all of this advice will dramatically
increase the risk your report will be rejected or ignored.
* Ensure the kernel you just installed does not 'taint' itself when
@@ -795,7 +795,7 @@ Install a fresh kernel for testing
situations; during the merge window that actually might be even the best
approach, but in that development phase it can be an even better idea to
suspend your efforts for a few days anyway. Whatever version you choose,
- ideally use a 'vanilla' built. Ignoring this advice will dramatically
+ ideally use a 'vanilla' built. Ignoring all of this advice will dramatically
increase the risk your report will be rejected or ignored.*
As mentioned in the detailed explanation for the first step already: Like most
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs: reporting-issues: clarify advice wording
2026-05-12 15:04 [PATCH] docs: reporting-issues: clarify advice wording Chen-Shi-Hong
@ 2026-05-13 8:08 ` Thorsten Leemhuis
0 siblings, 0 replies; 2+ messages in thread
From: Thorsten Leemhuis @ 2026-05-13 8:08 UTC (permalink / raw)
To: Chen-Shi-Hong; +Cc: corbet, skhan, linux-doc, linux-kernel
On 5/12/26 17:04, Chen-Shi-Hong wrote:
> A previous change
You mean the one you sent earlier we discussed? But that was not
applied, unless I'm missing something. So this should have been a v2 of
your patch (which a changelog) and against the same base (the one that
"these advices"). You want to send that as v3 now.
> replaced "these advices" with "this advice", but that
> wording can be read too narrowly and may seem to refer only to a single
> recommendation.
>
> Use "all of this advice" instead
That's great, thx. And thx to Jonathan for the suggestion!
Ciao, Thorsten
> to make it clearer that the sentence
> refers to the broader set of recommendations in the paragraph.
>
> Signed-off-by: Chen-Shi-Hong <eric039eric@gmail.com>
> ---
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 731865b5e8ff..87dd874fffcf 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' build. Ignoring this advice will dramatically
> + ideally use a 'vanilla' build. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.
>
> * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' built. Ignoring this advice will dramatically
> + ideally use a 'vanilla' built. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.*
>
> As mentioned in the detailed explanation for the first step already: Like most
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-13 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12 15:04 [PATCH] docs: reporting-issues: clarify advice wording Chen-Shi-Hong
2026-05-13 8:08 ` Thorsten Leemhuis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox