* [PATCH v9] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
@ 2026-05-12 12:26 Ashwin Gundarapu
2026-05-12 12:36 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Ashwin Gundarapu @ 2026-05-12 12:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging
From: Ashwin Gundarapu <linuxuser509@zohomail.in>
Date: Tue, 12 May 2026 17:54:37 +0530
Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Remove braces around single statement blocks.
Found by checkpatch.pl --strict
Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
---
v9: Removed git header from email body. Fixed all blank line issues.
Single blank line between statements only.
v8: Fixed double blank lines.
v7: Added version changelog below the --- line.
v6: Fixed indentation and removed trailing whitespace. Rebased against staging-next.
v5: Removed git header from email body. Fixed indentation on the second line of the function call. Added full version history.
v4: Moved changelog below the --- separator. Ran checkpatch.pl.
v3: Fixed double --- line and corrected whitespace formatting.
v2: Resent with corrected whitespace via Thunderbird plain text mode.
v1: Initial patch submission removing unnecessary comparison to true.
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 3d88a3a185d5..22776af126ca 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -483,7 +483,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
break;
}
-
if (rtw_roam_flags(adapter))
/* TODO: don't select network in the same ess as oldest if it's new enough*/
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v9] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
2026-05-12 12:26 [PATCH v9] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Ashwin Gundarapu
@ 2026-05-12 12:36 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2026-05-12 12:36 UTC (permalink / raw)
To: Ashwin Gundarapu; +Cc: linux-kernel, linux-staging
On Tue, May 12, 2026 at 05:56:46PM +0530, Ashwin Gundarapu wrote:
>
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Tue, 12 May 2026 17:54:37 +0530
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c
Please please slow down, otherwise you are going to end up on our email
filters, and we will just ignore your patches.
Stop for a few days, go back and read ALL of the review comments, and
then make a new patch. What you sent here is totally wrong still :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-12 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12 12:26 [PATCH v9] staging: rtl8723bs: remove unnecessary braces in rtw_mlme.c Ashwin Gundarapu
2026-05-12 12:36 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox