Re: [PATCH] tracing: Switch trace_recursion_record.c code over to use guard()

Re: [PATCH] tracing: Switch trace_recursion_record.c code over to use guard()

[Yash Suthar]

Gentle ping.

Sincerely,
Yash Suthar

On Sat, May 2, 2026 at 11:17 PM Yash Suthar <yashsuthar983@gmail.com> wrote:
>
> Switch mutex_lock()/mutex_unlock() to guard().
> also drop the ret local variable and return directly.
>
> Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
> ---
>  kernel/trace/trace_recursion_record.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/trace/trace_recursion_record.c b/kernel/trace/trace_recursion_record.c
> index 784fe1fbb866..bac4bc844ccd 100644
> --- a/kernel/trace/trace_recursion_record.c
> +++ b/kernel/trace/trace_recursion_record.c
> @@ -180,9 +180,8 @@ static const struct seq_operations recursed_function_seq_ops = {
>
>  static int recursed_function_open(struct inode *inode, struct file *file)
>  {
> -       int ret = 0;
> +       guard(mutex)(&recursed_function_lock);
>
> -       mutex_lock(&recursed_function_lock);
>         /* If this file was opened for write, then erase contents */
>         if ((file->f_mode & FMODE_WRITE) && (file->f_flags & O_TRUNC)) {
>                 /* disable updating records */
> @@ -194,10 +193,9 @@ static int recursed_function_open(struct inode *inode, struct file *file)
>                 atomic_set(&nr_records, 0);
>         }
>         if (file->f_mode & FMODE_READ)
> -               ret = seq_open(file, &recursed_function_seq_ops);
> -       mutex_unlock(&recursed_function_lock);
> +               return seq_open(file, &recursed_function_seq_ops);
>
> -       return ret;
> +       return 0;
>  }
>
>  static ssize_t recursed_function_write(struct file *file,
> --
> 2.43.0
>

Re: [PATCH] tracing: Switch trace_recursion_record.c code over to use guard()

[Steven Rostedt]

On Tue, 12 May 2026 20:11:08 +0530
Yash Suthar <yashsuthar983@gmail.com> wrote:

> Gentle ping.

Hi,

What's the rush? This is just a clean up change. There's no feature here
that you need is there?

If you see it in patchwork[1], it's not lost. I just have other things
ahead of it. I usually process cleanup code last.

Thanks,

-- Steve

[1] https://patchwork.kernel.org/project/linux-trace-kernel/patch/20260502174741.39636-1-yashsuthar983@gmail.com/