* Re: [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist [not found] <20260410-james-spe-discard-warning-v1-1-985c02756ee4@linaro.org> @ 2026-05-13 10:20 ` Leo Yan 2026-05-13 12:55 ` Ian Rogers 0 siblings, 1 reply; 2+ messages in thread From: Leo Yan @ 2026-05-13 10:20 UTC (permalink / raw) To: James Clark Cc: John Garry, Will Deacon, Mike Leach, Leo Yan, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter, linux-arm-kernel, linux-perf-users, linux-kernel On Fri, Apr 10, 2026 at 12:05:12PM +0100, James Clark wrote: > Opening an SPE event shows a warning that doesn't concern the user: > > $ perf record -e arm_spe > Unknown/empty format name: discard > > Perf only wants to know if the discard bit is set for configuring the > event, not in response to anything the user has done. Fix it by adding > another helper that returns if a config bit exists without warning. > > We should probably keep the warning in evsel__get_config_val() to avoid > having every caller having to do it, and most format bits should never > be missing. > > Add a test for the new helper. Rename the parent test function to be > more generic rather than adding a new one as it requires a lot of > boilerplate. > > Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Leo Yan <leo.yan@arm.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist 2026-05-13 10:20 ` [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist Leo Yan @ 2026-05-13 12:55 ` Ian Rogers 0 siblings, 0 replies; 2+ messages in thread From: Ian Rogers @ 2026-05-13 12:55 UTC (permalink / raw) To: Leo Yan Cc: James Clark, John Garry, Will Deacon, Mike Leach, Leo Yan, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-arm-kernel, linux-perf-users, linux-kernel On Wed, May 13, 2026 at 3:20 AM Leo Yan <leo.yan@arm.com> wrote: > > On Fri, Apr 10, 2026 at 12:05:12PM +0100, James Clark wrote: > > Opening an SPE event shows a warning that doesn't concern the user: > > > > $ perf record -e arm_spe > > Unknown/empty format name: discard > > > > Perf only wants to know if the discard bit is set for configuring the > > event, not in response to anything the user has done. Fix it by adding > > another helper that returns if a config bit exists without warning. > > > > We should probably keep the warning in evsel__get_config_val() to avoid > > having every caller having to do it, and most format bits should never > > be missing. > > > > Add a test for the new helper. Rename the parent test function to be > > more generic rather than adding a new one as it requires a lot of > > boilerplate. > > > > Signed-off-by: James Clark <james.clark@linaro.org> > > Reviewed-by: Leo Yan <leo.yan@arm.com> Reviewed-by: Ian Rogers <irogers@google.com> Thanks, Ian ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-13 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260410-james-spe-discard-warning-v1-1-985c02756ee4@linaro.org>
2026-05-13 10:20 ` [PATCH] perf arm-spe: Don't warn about the discard bit if it doesn't exist Leo Yan
2026-05-13 12:55 ` Ian Rogers
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox