The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] jfs: check sb_set_blocksize() return value in jfs_fill_super()
@ 2026-05-14 16:07 Daiki Harada
  0 siblings, 0 replies; only message in thread
From: Daiki Harada @ 2026-05-14 16:07 UTC (permalink / raw)
  To: jfs-discussion, linux-kernel
  Cc: Dave Kleikamp, Christian Brauner, Al Viro, Kees Cook,
	Daiki Harada, syzbot+32ec8b5bd050c78741c2

jfs_fill_super() does not check the return value of sb_set_blocksize().
If the block device's logical block size exceeds PAGE_SIZE,
sb_set_blocksize() fails and returns 0, but jfs_fill_super() continues
regardless. Subsequent sb_bread() calls then trigger a BUG() in
folio_alloc_buffers() because the block size is incompatible with the
folio size.

Fix by checking the return value of sb_set_blocksize() and failing the
mount with -EINVAL if it returns 0.

Reported-by: syzbot+32ec8b5bd050c78741c2@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=32ec8b5bd050c78741c2
Signed-off-by: Daiki Harada <daiky0325@gmail.com>

diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index 61575f7397ae..c69fc7677a66 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -491,8 +491,12 @@ static int jfs_fill_super(struct super_block *sb, struct fs_context *fc)
 	/*
 	 * Initialize blocksize to 4K.
 	 */
-	sb_set_blocksize(sb, PSIZE);
-
+	if (!sb_set_blocksize(sb, PSIZE)) {
+		jfs_err("block size %lu > page size %lu not supported",
+			sb->s_blocksize, PAGE_SIZE);
+		ret = -EINVAL;
+		goto out_unload;
+	}
 	/*
 	 * Set method vectors.
 	 */
---


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-05-14 16:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-14 16:07 [PATCH] jfs: check sb_set_blocksize() return value in jfs_fill_super() Daiki Harada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox