* [PATCH] crypto: ecrdsa - remove empty sig_alg exit callback
@ 2026-05-19 8:36 Thorsten Blum
2026-05-19 10:14 ` Lukas Wunner
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-05-19 8:36 UTC (permalink / raw)
To: Lukas Wunner, Ignat Korchagin, Herbert Xu, David S. Miller
Cc: Thorsten Blum, linux-crypto, linux-kernel
ecrdsa_exit_tfm() is empty, and sig_alg .exit is optional. The
corresponding .init callback is not set either, so there is nothing to
release in .exit.
Remove the empty function and leave .exit unset.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
crypto/ecrdsa.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/crypto/ecrdsa.c b/crypto/ecrdsa.c
index 2c0602f0cd40..4fb9906b47a8 100644
--- a/crypto/ecrdsa.c
+++ b/crypto/ecrdsa.c
@@ -259,16 +259,11 @@ static unsigned int ecrdsa_max_size(struct crypto_sig *tfm)
return 2 * ctx->pub_key.ndigits * sizeof(u64);
}
-static void ecrdsa_exit_tfm(struct crypto_sig *tfm)
-{
-}
-
static struct sig_alg ecrdsa_alg = {
.verify = ecrdsa_verify,
.set_pub_key = ecrdsa_set_pub_key,
.key_size = ecrdsa_key_size,
.max_size = ecrdsa_max_size,
- .exit = ecrdsa_exit_tfm,
.base = {
.cra_name = "ecrdsa",
.cra_driver_name = "ecrdsa-generic",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: ecrdsa - remove empty sig_alg exit callback
2026-05-19 8:36 [PATCH] crypto: ecrdsa - remove empty sig_alg exit callback Thorsten Blum
@ 2026-05-19 10:14 ` Lukas Wunner
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Wunner @ 2026-05-19 10:14 UTC (permalink / raw)
To: Thorsten Blum
Cc: Ignat Korchagin, Herbert Xu, David S. Miller, linux-crypto,
linux-kernel
On Tue, May 19, 2026 at 10:36:32AM +0200, Thorsten Blum wrote:
> ecrdsa_exit_tfm() is empty, and sig_alg .exit is optional. The
> corresponding .init callback is not set either, so there is nothing to
> release in .exit.
>
> Remove the empty function and leave .exit unset.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-19 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-19 8:36 [PATCH] crypto: ecrdsa - remove empty sig_alg exit callback Thorsten Blum
2026-05-19 10:14 ` Lukas Wunner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox