The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node
@ 2026-03-20  7:07 Andy Shevchenko
  2026-05-06  9:49 ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-03-20  7:07 UTC (permalink / raw)
  To: Craig McQueen, Andy Shevchenko, linux-kernel

Adjust documentation of brightness sysfs node about accepted value range.
The code accepts only decimal values. We may not relax that due to different
readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
100.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v2: rephrased the sentence to make it clearer (Lee)

 Documentation/ABI/testing/sysfs-class-led | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
index 0313b82644f2..d4c918cc11a1 100644
--- a/Documentation/ABI/testing/sysfs-class-led
+++ b/Documentation/ABI/testing/sysfs-class-led
@@ -22,8 +22,8 @@ Description:
 		  For additional details please refer to
 		  Documentation/leds/leds-class-multicolor.rst.
 
-		The value is between 0 and
-		/sys/class/leds/<led>/max_brightness.
+		The value is between 0 and /sys/class/leds/<led>/max_brightness
+		and is represented by as a decimal.
 
 		Writing 0 to this file clears active trigger.
 
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node
  2026-03-20  7:07 [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node Andy Shevchenko
@ 2026-05-06  9:49 ` Andy Shevchenko
  2026-05-07  8:30   ` Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-05-06  9:49 UTC (permalink / raw)
  To: Craig McQueen, linux-kernel; +Cc: Lee Jones

On Fri, Mar 20, 2026 at 08:07:05AM +0100, Andy Shevchenko wrote:
> Adjust documentation of brightness sysfs node about accepted value range.
> The code accepts only decimal values. We may not relax that due to different
> readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> 100.

Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node
  2026-05-06  9:49 ` Andy Shevchenko
@ 2026-05-07  8:30   ` Lee Jones
  2026-05-13 22:06     ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2026-05-07  8:30 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Craig McQueen, linux-kernel

On Wed, 06 May 2026, Andy Shevchenko wrote:

> On Fri, Mar 20, 2026 at 08:07:05AM +0100, Andy Shevchenko wrote:
> > Adjust documentation of brightness sysfs node about accepted value range.
> > The code accepts only decimal values. We may not relax that due to different
> > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > 100.
> 
> Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.

This is not in my inbox.  Please [RESEND].

-- 
Lee Jones

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node
  2026-05-07  8:30   ` Lee Jones
@ 2026-05-13 22:06     ` Andy Shevchenko
  2026-05-20 15:48       ` Lee Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-05-13 22:06 UTC (permalink / raw)
  To: Lee Jones; +Cc: Craig McQueen, linux-kernel

On Thu, May 07, 2026 at 09:30:09AM +0100, Lee Jones wrote:
> On Wed, 06 May 2026, Andy Shevchenko wrote:
> > On Fri, Mar 20, 2026 at 08:07:05AM +0100, Andy Shevchenko wrote:
> > > Adjust documentation of brightness sysfs node about accepted value range.
> > > The code accepts only decimal values. We may not relax that due to different
> > > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > > 100.
> > 
> > Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.
> 
> This is not in my inbox.  Please [RESEND].

Done as 20260513220620.369825-1-andriy.shevchenko@linux.intel.com.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node
  2026-05-13 22:06     ` Andy Shevchenko
@ 2026-05-20 15:48       ` Lee Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2026-05-20 15:48 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Craig McQueen, linux-kernel

On Thu, 14 May 2026, Andy Shevchenko wrote:

> On Thu, May 07, 2026 at 09:30:09AM +0100, Lee Jones wrote:
> > On Wed, 06 May 2026, Andy Shevchenko wrote:
> > > On Fri, Mar 20, 2026 at 08:07:05AM +0100, Andy Shevchenko wrote:
> > > > Adjust documentation of brightness sysfs node about accepted value range.
> > > > The code accepts only decimal values. We may not relax that due to different
> > > > readings for, e.g., octal 0100, which becomes 64 instead of currently parsed
> > > > 100.
> > > 
> > > Lee, Can we have this being applied? Perhaps even for this (v7.1) cycle.
> > 
> > This is not in my inbox.  Please [RESEND].
> 
> Done as 20260513220620.369825-1-andriy.shevchenko@linux.intel.com.

Still didn't end up in my inbox, oddly!

Applied with external tooling.

-- 
Lee Jones

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-20 15:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-20  7:07 [PATCH v2 1/1] leds: Adjust documentation of brightness sysfs node Andy Shevchenko
2026-05-06  9:49 ` Andy Shevchenko
2026-05-07  8:30   ` Lee Jones
2026-05-13 22:06     ` Andy Shevchenko
2026-05-20 15:48       ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox