The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH v1 1/1] fs/read_write: Do not export __kernel_write() to the entire world
@ 2026-06-04  9:28 Andy Shevchenko
  2026-06-04  9:46 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2026-06-04  9:28 UTC (permalink / raw)
  To: Christian Brauner (Amutable), linux-fsdevel, linux-kernel
  Cc: Al Viro, Jan Kara, Andy Shevchenko

Since we have EXPORT_SYMBOL_FOR_MODULES(), we may narrow
the __kernel_write() export to the only which really needs it.
With that being done, update the respective comment.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 fs/read_write.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index 1e5444f4dab3..1f50f5d015ec 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -641,13 +641,12 @@ ssize_t __kernel_write(struct file *file, const void *buf, size_t count, loff_t
 	return __kernel_write_iter(file, &iter, pos);
 }
 /*
- * This "EXPORT_SYMBOL_GPL()" is more of a "EXPORT_SYMBOL_DONTUSE()",
- * but autofs is one of the few internal kernel users that actually
+ * autofs is one of the few internal kernel users that actually
  * wants this _and_ can be built as a module. So we need to export
  * this symbol for autofs, even though it really isn't appropriate
  * for any other kernel modules.
  */
-EXPORT_SYMBOL_GPL(__kernel_write);
+EXPORT_SYMBOL_GPL_FOR_MODULES(__kernel_write, "autofs");
 
 ssize_t kernel_write(struct file *file, const void *buf, size_t count,
 			    loff_t *pos)
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] fs/read_write: Do not export __kernel_write() to the entire world
  2026-06-04  9:28 [PATCH v1 1/1] fs/read_write: Do not export __kernel_write() to the entire world Andy Shevchenko
@ 2026-06-04  9:46 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-06-04  9:46 UTC (permalink / raw)
  To: Christian Brauner (Amutable), linux-fsdevel, linux-kernel
  Cc: Al Viro, Jan Kara

On Thu, Jun 04, 2026 at 11:28:21AM +0200, Andy Shevchenko wrote:

...

> -EXPORT_SYMBOL_GPL(__kernel_write);
> +EXPORT_SYMBOL_GPL_FOR_MODULES(__kernel_write, "autofs");

Sorry, The GPL here was removed in a somewhat recent kernels. This won't build
on the current. I will send a v2.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-04  9:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-04  9:28 [PATCH v1 1/1] fs/read_write: Do not export __kernel_write() to the entire world Andy Shevchenko
2026-06-04  9:46 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox