From: Jakub Kicinski <kuba@kernel.org>
To: Yizhou Zhao <zhaoyz24@mails.tsinghua.edu.cn>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Yuxiang Yang <yangyx22@mails.tsinghua.edu.cn>,
Ao Wang <wangao@seu.edu.cn>, Xuewei Feng <fengxw06@126.com>,
Qi Li <qli01@tsinghua.edu.cn>, Ke Xu <xuke@tsinghua.edu.cn>
Subject: Re: [PATCH net] vlan: prevent cross-netns promisc/allmulti propagation
Date: Tue, 9 Jun 2026 18:37:15 -0700 [thread overview]
Message-ID: <20260609183715.006f7bd4@kernel.org> (raw)
In-Reply-To: <20260607113529.98178-1-zhaoyz24@mails.tsinghua.edu.cn>
On Sun, 7 Jun 2026 19:35:28 +0800 Yizhou Zhao wrote:
> vlan_dev_change_rx_flags() propagates IFF_PROMISC and IFF_ALLMULTI
> changes from a VLAN device to its real device. If the VLAN device has
> been moved to another network namespace, a user with CAP_NET_ADMIN in
> that namespace can toggle these flags on the VLAN device and change the
> promiscuity/allmulti counters on the real device in the original
> namespace.
I'd think that's expected. There's a higher chance this patch will
break someone's intentional setup than prevent an issue...
If anyone on the list disagrees please speak up
--
pw-bot: reject
prev parent reply other threads:[~2026-06-10 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 11:35 [PATCH net] vlan: prevent cross-netns promisc/allmulti propagation Yizhou Zhao
2026-06-10 1:37 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609183715.006f7bd4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fengxw06@126.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qli01@tsinghua.edu.cn \
--cc=stable@vger.kernel.org \
--cc=wangao@seu.edu.cn \
--cc=xuke@tsinghua.edu.cn \
--cc=yangyx22@mails.tsinghua.edu.cn \
--cc=zhaoyz24@mails.tsinghua.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox