* [PATCH net-next] net: pse-pd: set user byte command SUB2 field
@ 2026-06-11 10:24 Robert Marko
2026-06-12 7:56 ` Kory Maincent
2026-06-13 22:59 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Robert Marko @ 2026-06-11 10:24 UTC (permalink / raw)
To: o.rempel, kory.maincent, andrew+netdev, davem, edumazet, kuba,
pabeni, netdev, linux-kernel
Cc: luka.perkov, Robert Marko
The Set User Byte to Save command has three subject bytes.
The PD692x0 protocol guides defines SUB2 with value 0x4e, while SUB1
carries the NVM user byte.
Template only initialized SUB and SUB1.
Fill SUB2 explicitly so the command matches the documented layout.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
drivers/net/pse-pd/pd692x0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/pse-pd/pd692x0.c b/drivers/net/pse-pd/pd692x0.c
index cb377d5ba7af..209de9cec849 100644
--- a/drivers/net/pse-pd/pd692x0.c
+++ b/drivers/net/pse-pd/pd692x0.c
@@ -200,7 +200,7 @@ static const struct pd692x0_msg pd692x0_msg_template_list[PD692X0_MSG_CNT] = {
},
[PD692X0_MSG_SET_USER_BYTE] = {
.key = PD692X0_KEY_PRG,
- .sub = {0x41, PD692X0_USER_BYTE},
+ .sub = {0x41, PD692X0_USER_BYTE, 0x4e},
.data = {0x4e, 0x4e, 0x4e, 0x4e,
0x4e, 0x4e, 0x4e, 0x4e},
},
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: pse-pd: set user byte command SUB2 field
2026-06-11 10:24 [PATCH net-next] net: pse-pd: set user byte command SUB2 field Robert Marko
@ 2026-06-12 7:56 ` Kory Maincent
2026-06-13 22:59 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Kory Maincent @ 2026-06-12 7:56 UTC (permalink / raw)
To: Robert Marko
Cc: o.rempel, andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, luka.perkov
On Thu, 11 Jun 2026 12:24:49 +0200
Robert Marko <robert.marko@sartura.hr> wrote:
> The Set User Byte to Save command has three subject bytes.
> The PD692x0 protocol guides defines SUB2 with value 0x4e, while SUB1
> carries the NVM user byte.
>
> Template only initialized SUB and SUB1.
> Fill SUB2 explicitly so the command matches the documented layout.
Acked-by: Kory Maincent <kory.maincent@bootlin.com>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: pse-pd: set user byte command SUB2 field
2026-06-11 10:24 [PATCH net-next] net: pse-pd: set user byte command SUB2 field Robert Marko
2026-06-12 7:56 ` Kory Maincent
@ 2026-06-13 22:59 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2026-06-13 22:59 UTC (permalink / raw)
To: Robert Marko
Cc: o.rempel, kory.maincent, andrew+netdev, davem, edumazet, pabeni,
netdev, linux-kernel, luka.perkov
On Thu, 11 Jun 2026 12:24:49 +0200 Robert Marko wrote:
> The Set User Byte to Save command has three subject bytes.
> The PD692x0 protocol guides defines SUB2 with value 0x4e, while SUB1
> carries the NVM user byte.
>
> Template only initialized SUB and SUB1.
> Fill SUB2 explicitly so the command matches the documented layout.
Could you mention if you observed any misbehavior in practice?
If you can see any effect of this patch it needs to include a Fixes tag
so that it can be backported.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-13 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 10:24 [PATCH net-next] net: pse-pd: set user byte command SUB2 field Robert Marko
2026-06-12 7:56 ` Kory Maincent
2026-06-13 22:59 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox