From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@analog.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: dac: ad3530r: Refactor setup to table-driven register bank approach
Date: Mon, 15 Jun 2026 09:22:19 +0200 [thread overview]
Message-ID: <20260615092219.00007709@gmail.com> (raw)
In-Reply-To: <20260615-iio-ad3532r-support-v2-1-84a0af8b83fa@analog.com>
On Mon, 15 Jun 2026 14:20:15 +0800
Kim Seer Paller <kimseer.paller@analog.com> wrote:
> @@ -344,7 +387,14 @@ static const struct ad3530r_chip_info ad3530r_chip = {
> .name = "ad3530r",
> .channels = ad3530r_channels,
> .num_channels = ARRAY_SIZE(ad3530r_channels),
> - .sw_ldac_trig_reg = AD3530R_SW_LDAC_TRIG_A,
> + .sw_ldac_trig_reg = ad3530r_trigger_sw_ldac_reg,
> + .input_ch_reg = ad3530r_input_ch_reg,
You're overwriting this field below.
> + .interface_config_a = ad3530r_if_config,
> + .output_control = ad3530r_out_ctrl,
> + .reference_control = ad3530r_ref_ctrl,
> + .op_mode = ad3530r_op_mode,
> + .num_banks = ARRAY_SIZE(ad3530r_if_config),
> + .num_op_mode_regs = ARRAY_SIZE(ad3530r_op_mode),
> .input_ch_reg = ad3530r_input_ch_reg,
Slight issue, this will cause an error if compiled with W=1, as
you've already initialized this field earlier. Remove this line.
--
Kind regards
CJD
next prev parent reply other threads:[~2026-06-15 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 6:20 [PATCH v2 0/4] Add support for AD3532R/AD3532 Kim Seer Paller
2026-06-15 6:20 ` [PATCH v2 1/4] iio: dac: ad3530r: Refactor setup to table-driven register bank approach Kim Seer Paller
2026-06-15 7:22 ` Joshua Crofts [this message]
2026-06-15 10:08 ` Andy Shevchenko
2026-06-15 6:20 ` [PATCH v2 2/4] iio: ABI: add DAC 10kohm_to_gnd powerdown mode Kim Seer Paller
2026-06-15 6:20 ` [PATCH v2 3/4] dt-bindings: iio: dac: add support for AD3532R/AD3532 Kim Seer Paller
2026-06-15 6:20 ` [PATCH v2 4/4] iio: dac: ad3530r: Add " Kim Seer Paller
2026-06-15 10:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615092219.00007709@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kimseer.paller@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox