From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Yury Norov <ynorov@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ao Sun <ao.sun@transsion.com>, David Carlier <devnexen@gmail.com>,
Karl Mehltretter <kmehltretter@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Qian-Yu Lin <tiffany019230@gmail.com>,
Rik van Riel <riel@surriel.com>, Rosen Penev <rosenp@gmail.com>,
Shuvam Pandey <shuvampandey1@gmail.com>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Yash Suthar <yashsuthar983@gmail.com>,
Yu Peng <pengyu@kylinos.cn>
Subject: Re: [GIT PULL] tracing: Updates for 7.2
Date: Fri, 19 Jun 2026 08:15:13 -0400 [thread overview]
Message-ID: <20260619081513.3e4a1fb0@fedora> (raw)
In-Reply-To: <CAHk-=wikCBeVFjVXiY4o-oepdbjAoir5+TcAgtL12c4u1TpZLQ@mail.gmail.com>
On Thu, 18 Jun 2026 21:23:04 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> The intent was clearly to make people who actually needed the
> trace_printk() functionality to include the header - that's what the
> commit log says. But that's not how any of it works ;(
>
> So all that commit did was to make things look like they wouldn't hurt
> as much as they do, and that trivial change to that file causes a full
> rebuild of the kernel.
>
> I'm not seeing any patches even being discussed that would make only
> files that need it to include that file and remove it from
> linux/kernel.h that *everybody* uses. Yet that was the *only* point of
> making it a separate header in the first place. Yury?
Many developers use trace_printk() over printk(). Requiring people to
add that include for every use case would severely limit debugging of
the kernel. Would you be OK if we did the same for printk? That is, if
you want to add a printk to a function, you had to add a include
printk.h to the file before doing so?
-- Steve
next prev parent reply other threads:[~2026-06-19 12:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 22:01 [GIT PULL] tracing: Updates for 7.2 Steven Rostedt
2026-06-19 4:23 ` Linus Torvalds
2026-06-19 12:15 ` Steven Rostedt [this message]
2026-06-19 14:35 ` Linus Torvalds
2026-06-19 15:40 ` Sebastian Andrzej Siewior
2026-06-19 15:43 ` Linus Torvalds
2026-06-19 18:30 ` Sebastian Andrzej Siewior
2026-06-19 19:07 ` Linus Torvalds
2026-06-19 20:28 ` Thomas Gleixner
2026-06-19 20:55 ` Linus Torvalds
2026-06-20 9:22 ` Willy Tarreau
2026-06-19 22:28 ` Linus Torvalds
2026-06-19 15:54 ` Steven Rostedt
2026-06-19 16:29 ` Linus Torvalds
2026-06-20 20:24 ` Julia Lawall
2026-06-20 22:19 ` Steven Rostedt
2026-06-20 22:39 ` Linus Torvalds
2026-06-20 23:43 ` Steven Rostedt
2026-06-21 0:18 ` Linus Torvalds
2026-06-21 6:34 ` Steven Rostedt
2026-06-21 7:10 ` Steven Rostedt
2026-06-19 15:19 ` Yury Norov
2026-06-19 15:40 ` Linus Torvalds
2026-06-19 22:18 ` Yury Norov
2026-06-19 4:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619081513.3e4a1fb0@fedora \
--to=rostedt@goodmis.org \
--cc=ao.sun@transsion.com \
--cc=devnexen@gmail.com \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=pengyu@kylinos.cn \
--cc=riel@surriel.com \
--cc=rosenp@gmail.com \
--cc=shuvampandey1@gmail.com \
--cc=tiffany019230@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vineeth@bitbyteword.org \
--cc=yashsuthar983@gmail.com \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox