From: Thomas Gleixner <tglx@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: John Ogness <john.ogness@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Yury Norov <ynorov@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ao Sun <ao.sun@transsion.com>, David Carlier <devnexen@gmail.com>,
Karl Mehltretter <kmehltretter@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Qian-Yu Lin <tiffany019230@gmail.com>,
Rik van Riel <riel@surriel.com>, Rosen Penev <rosenp@gmail.com>,
Shuvam Pandey <shuvampandey1@gmail.com>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Yash Suthar <yashsuthar983@gmail.com>,
Yu Peng <pengyu@kylinos.cn>
Subject: Re: [GIT PULL] tracing: Updates for 7.2
Date: Fri, 19 Jun 2026 22:28:22 +0200 [thread overview]
Message-ID: <87tsqyb7h5.ffs@fw13> (raw)
In-Reply-To: <CAHk-=wjFp+aWSRX+tCR=shi_qP5zsEi5eyQp4DL48DeYh_4V3w@mail.gmail.com>
On Fri, Jun 19 2026 at 12:07, Linus Torvalds wrote:
> On Fri, 19 Jun 2026 at 11:30, Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
> But in general, if the question is "should we split this header file
> up if it's straightforward and easy", the answer is *ALWAYS* a
> resounding "YES".
Full ACK.
> Most of the time it's just a pain to unravel all the type
> dependencies. This case look strivial compared to some we've done.
>
> One of the things I at one point hoped sparse would do was a "you're
> including this header for no good reason" tooling.
>
> But it's non-trivial to do, particularly with lots of different
> architectures that aren't very consistent in where they declare or use
> things.
That's only one part of the overall problem.
People are really careless when they add new things. It took me
literally weeks to handle all the 0-day compile fallout when I tried to
disentangle the __percpu mess so that a header using a __percpu
annotation in a struct declaration is not required to include the world
and running into recursive header hell.
See c06cd66387da ("percpu: Sanitize __percpu_qual include hell")
I'm still fighting to resolve the last remaining issue to get rid of the
asm/xtime.h dependency in some other cleanup project. That header is so
deeply ingrained in some of our header chains for the very wrong
reasons.
I've tried to utilize AI for analyzing it, but that ended up in an even
bigger disaster.
One thing I'm seeing is that the kernel is patently bad in separating
data type declarations from actual APIs, where the APIs usually just
need a forward declaration of the pointer type. Ditto for struct
declarations with pointer types.
After doing quite some of these disentanglements manually and trying to
utilize all kinds of tooling, I still have no good answer to this
unfortunately.
Thanks,
tglx
next prev parent reply other threads:[~2026-06-19 20:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 22:01 [GIT PULL] tracing: Updates for 7.2 Steven Rostedt
2026-06-19 4:23 ` Linus Torvalds
2026-06-19 12:15 ` Steven Rostedt
2026-06-19 14:35 ` Linus Torvalds
2026-06-19 15:40 ` Sebastian Andrzej Siewior
2026-06-19 15:43 ` Linus Torvalds
2026-06-19 18:30 ` Sebastian Andrzej Siewior
2026-06-19 19:07 ` Linus Torvalds
2026-06-19 20:28 ` Thomas Gleixner [this message]
2026-06-19 20:55 ` Linus Torvalds
2026-06-20 9:22 ` Willy Tarreau
2026-06-19 22:28 ` Linus Torvalds
2026-06-19 15:54 ` Steven Rostedt
2026-06-19 16:29 ` Linus Torvalds
2026-06-20 20:24 ` Julia Lawall
2026-06-20 22:19 ` Steven Rostedt
2026-06-20 22:39 ` Linus Torvalds
2026-06-20 23:43 ` Steven Rostedt
2026-06-21 0:18 ` Linus Torvalds
2026-06-21 6:34 ` Steven Rostedt
2026-06-21 7:10 ` Steven Rostedt
2026-06-19 15:19 ` Yury Norov
2026-06-19 15:40 ` Linus Torvalds
2026-06-19 22:18 ` Yury Norov
2026-06-19 4:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsqyb7h5.ffs@fw13 \
--to=tglx@kernel.org \
--cc=ao.sun@transsion.com \
--cc=bigeasy@linutronix.de \
--cc=devnexen@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=pengyu@kylinos.cn \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rosenp@gmail.com \
--cc=rostedt@goodmis.org \
--cc=shuvampandey1@gmail.com \
--cc=tiffany019230@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vineeth@bitbyteword.org \
--cc=yashsuthar983@gmail.com \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox