From: Lee Jones <lee@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rohm: Factor out power button registration
Date: Fri, 19 Jun 2026 10:02:46 +0100 [thread overview]
Message-ID: <20260619090246.GC2108533@google.com> (raw)
In-Reply-To: <ajQ-CtU131FAJ9ES@google.com>
On Thu, 18 Jun 2026, Dmitry Torokhov wrote:
> Factor out the power button registration logic using software nodes
> from rohm-bd718x7 and rohm-bd71828 drivers into a shared module
> rohm-pwrbutton.
>
> This reduces duplication and makes it easier to support other ROHM
> PMICs with similar power button configurations.
>
> Suggested-by: Lee Jones <lee@kernel.org>
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Quick drive-by nit: Drop the term 'mfd' from function names please.
> ---
> MAINTAINERS | 2 +
> drivers/mfd/Kconfig | 6 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/rohm-bd71828.c | 84 ++------------------------
> drivers/mfd/rohm-bd718x7.c | 84 ++------------------------
> drivers/mfd/rohm-pwrbutton.c | 112 +++++++++++++++++++++++++++++++++++
> drivers/mfd/rohm-pwrbutton.h | 12 ++++
> 7 files changed, 141 insertions(+), 160 deletions(-)
--
Lee Jones
prev parent reply other threads:[~2026-06-19 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 18:58 [PATCH] mfd: rohm: Factor out power button registration Dmitry Torokhov
2026-06-19 9:02 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619090246.GC2108533@google.com \
--to=lee@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox