From: Boris Brezillon <boris.brezillon@collabora.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: "Rob Herring" <robh@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"Adrián Larumbe" <adrian.larumbe@collabora.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage
Date: Tue, 23 Jun 2026 13:00:05 +0200 [thread overview]
Message-ID: <20260623130005.77a3d669@fedora-2.home> (raw)
In-Reply-To: <20260623104617.768289-1-ben.dooks@codethink.co.uk>
On Tue, 23 Jun 2026 11:46:17 +0100
Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The panfrost_transparent_hugepage variable is declared in panfrost_drv.h
> but the panfrost_drv.c does not incldue this header. Fix the following
> sparse warning by including panfrost_drv.h :
>
> drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 784e36d72c2b..36cc2e67a308 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -21,6 +21,7 @@
> #include <drm/drm_utils.h>
>
> #include "panfrost_device.h"
> +#include "panfrost_drv.h"
> #include "panfrost_gem.h"
> #include "panfrost_mmu.h"
> #include "panfrost_job.h"
next prev parent reply other threads:[~2026-06-23 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 10:46 [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage Ben Dooks
2026-06-23 11:00 ` Boris Brezillon [this message]
2026-06-23 14:57 ` Adrián Larumbe
2026-06-24 15:19 ` Steven Price
2026-07-10 18:26 ` Adrián Larumbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623130005.77a3d669@fedora-2.home \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox