From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: jic23@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 0/2] iio: adc: ad7779: Remove dead code and redundant error message
Date: Sun, 28 Jun 2026 19:13:50 +0200 [thread overview]
Message-ID: <20260628191350.583470a7@systembl0wer> (raw)
In-Reply-To: <20260628145734.77191-1-mokshpanicker.7@gmail.com>
On Sun, 28 Jun 2026 14:57:32 +0000
Moksh Panicker <mokshpanicker.7@gmail.com> wrote:
> These two patches address review feedback from Joshua Crofts on the
> ad7779 driver:
>
> 1. Remove an unused completion field that was initialized but never
> waited on or signaled anywhere in the driver.
>
> 2. Remove a redundant dev_err_probe() wrapper around devm_request_irq(),
> which already calls dev_err_probe() internally.
>
> Moksh Panicker (2):
> iio: adc: ad7779: Remove unused completion field
> iio: adc: ad7779: Remove redundant dev_err_probe() after
> devm_request_irq()
>
> drivers/iio/adc/ad7779.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
You forgot to pull my Reviewed-by tags, no need to resend:
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards
CJD
prev parent reply other threads:[~2026-06-28 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 14:57 [PATCH v2 0/2] iio: adc: ad7779: Remove dead code and redundant error message Moksh Panicker
2026-06-28 14:57 ` [PATCH v2 1/2] iio: adc: ad7779: Remove unused completion field Moksh Panicker
2026-06-28 14:57 ` [PATCH v2 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq() Moksh Panicker
2026-06-28 17:13 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260628191350.583470a7@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mokshpanicker.7@gmail.com \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox