The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
	Zhan Xusheng <zhanxusheng@xiaomi.com>,
	Ingo Molnar <mingo@kernel.org>,
	x86@kernel.org
Subject: Re: [tip: sched/urgent] sched/fair: Fix stale comments referring to removed CFS concepts
Date: Tue, 30 Jun 2026 11:10:15 +0200	[thread overview]
Message-ID: <20260630091015.GA651302@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <178273159419.3843924.17455384806679869461.tip-bot2@tip-bot2>

On Mon, Jun 29, 2026 at 11:13:14AM -0000, tip-bot2 for Zhan Xusheng wrote:
> The following commit has been merged into the sched/urgent branch of tip:
> 
> Commit-ID:     17fdabfa3aeca3d07846a8d56ac0abf61b58bffd
> Gitweb:        https://git.kernel.org/tip/17fdabfa3aeca3d07846a8d56ac0abf61b58bffd
> Author:        Zhan Xusheng <zhanxusheng1024@gmail.com>
> AuthorDate:    Mon, 29 Jun 2026 11:02:00 +08:00
> Committer:     Ingo Molnar <mingo@kernel.org>
> CommitterDate: Mon, 29 Jun 2026 13:11:52 +02:00
> 
> sched/fair: Fix stale comments referring to removed CFS concepts
> 
> A few comments still describe the pre-EEVDF CFS world:
> 
>  - sysctl_sched_base_slice is documented as "Minimal preemption
>    granularity for CPU-bound tasks".  That was the wording of the old
>    sysctl_sched_min_granularity, renamed in commit e4ec3318a17f
>    ("sched/debug: Rename sysctl_sched_min_granularity to
>    sysctl_sched_base_slice").  Under EEVDF it is the default base time
>    slice / request size (r_i) used to compute the virtual deadline, as
>    documented in update_deadline().
> 
>  - Two comments still mention sched_slice(), which was removed when the
>    fair class committed to EEVDF in commit 5e963f2bd465 ("sched/fair:
>    Commit to EEVDF").  The dequeue-path comment should simply refer to
>    the task's slice (se->slice); the forced-idle comment describes the
>    slice accounting now performed by __entity_slice_used(), which is the
>    function actually used right below it.
> 
> No functional changes.
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Link: https://patch.msgid.link/20260629030200.3165589-1-zhanxusheng@xiaomi.com

This is comments, cannot be urgent. Also generates non-trivial conflicts
against the patches I just stuck in sched/core. So zapped this commit.

  reply	other threads:[~2026-06-30  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  3:02 [PATCH] sched/fair: Fix stale comments referring to removed CFS concepts Zhan Xusheng
2026-06-29 11:13 ` [tip: sched/urgent] " tip-bot2 for Zhan Xusheng
2026-06-30  9:10   ` Peter Zijlstra [this message]
2026-06-30 11:33     ` Ingo Molnar
2026-06-30 11:32 ` [tip: sched/core] " tip-bot2 for Zhan Xusheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260630091015.GA651302@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=x86@kernel.org \
    --cc=zhanxusheng@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox