[PATCH v3] media: atomisp: fix block comment formatting style

[PATCH v3] media: atomisp: fix block comment formatting style

[Bohdan D. Marcus]

Fix a block comment formatting warning reported by
checkpatch.pl in atomisp_cmd.c to conform to the
Linux kernel coding style.

Signed-off-by: Bohdan D. Marcus <bohdandmarcus@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9fd26..20abc2c0de80 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -2520,9 +2520,12 @@ int atomisp_css_cp_dvs2_coefs(struct atomisp_sub_device *asd,
 		if (sizeof(*cur) != sizeof(dvs2_coefs.grid) ||
 		    memcmp(&dvs2_coefs.grid, cur, sizeof(dvs2_coefs.grid))) {
 			dev_err(asd->isp->dev, "dvs grid mismatch!\n");
-			/* If the grid info in the argument differs from the current
-			grid info, we tell the caller to reset the grid size and
-			try again. */
+						/*
+						 * If the grid info in the argument differs
+						 * from the current grid info, we tell the
+						 * caller to reset the grid size and try
+						 * again.
+						 */
 			return -EAGAIN;
 		}
 
-- 
2.55.0

Re: [PATCH v3] media: atomisp: fix block comment formatting style

[Andy Shevchenko]

On Tue, Jun 30, 2026 at 7:06 PM Bohdan D. Marcus
<bohdandmarcus@gmail.com> wrote:
>
> Fix a block comment formatting warning reported by
> checkpatch.pl in atomisp_cmd.c to conform to the
> Linux kernel coding style.

Almost the same comments as per v2. Please, slow down, read other
comments and act accordingly.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3] media: atomisp: fix block comment formatting style

[Bohdan Derkach]

Hi Andy,

Thank you for the review.

You are completely right about the indentation and line wraps. Dan
Carpenter also pointed this out to me yesterday, and I have already
prepared a v4 that fixes all of these issues perfectly. I am strictly
following the rule to wait a full 24 hours between sending versions,
so I will send v4 later today.

Regarding your question about whether this is the only issue in the driver:
I understand that sending a patch for a single block comment in a 100k
LoC driver is a very small contribution. Since this is my very first
patch to the Linux kernel, my main goal was to learn the correct
workflow (git send-email, formatting versions, acting on feedback)
before sending larger patch series.

Once this v4 is accepted and I am confident that my setup is correct,
my next step is to grep through the rest of atomisp to fix similar
block comments and submit them as a proper patch series.

Thank you for your patience and for guiding a newcomer!

Regards,
Bohdan


On Wed, Jul 1, 2026 at 11:42 AM Bohdan Derkach <bohdandmarcus@gmail.com> wrote:
>
> Hi Andy,
>
> Thank you for the review.
>
> You are completely right about the indentation and line wraps. Dan Carpenter also pointed this out to me yesterday, and I have already prepared a v4 that fixes all of these issues perfectly. I am strictly following the rule to wait a full 24 hours between sending versions, so I will send v4 later today.
>
> Regarding your question about whether this is the only issue in the driver:
> I understand that sending a patch for a single block comment in a 100k LoC driver is a very small contribution. Since this is my very first patch to the Linux kernel, my main goal was to learn the correct workflow (git send-email, formatting versions, acting on feedback) before sending larger patch series.
>
> Once this v4 is accepted and I am confident that my setup is correct, my next step is to grep through the rest of atomisp to fix similar block comments and submit them as a proper patch series.
>
> Thank you for your patience and for guiding a newcomer!
>
> Regards,
> Bohdan
>
> On Wed, Jul 1, 2026 at 11:31 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>
>> On Tue, Jun 30, 2026 at 7:06 PM Bohdan D. Marcus
>> <bohdandmarcus@gmail.com> wrote:
>> >
>> > Fix a block comment formatting warning reported by
>> > checkpatch.pl in atomisp_cmd.c to conform to the
>> > Linux kernel coding style.
>>
>> Almost the same comments as per v2. Please, slow down, read other
>> comments and act accordingly.
>>
>> --
>> With Best Regards,
>> Andy Shevchenko

Re: [PATCH v3] media: atomisp: fix block comment formatting style

[Andy Shevchenko]

On Wed, Jul 01, 2026 at 11:51:43AM +0300, Bohdan Derkach wrote:

First of all, do not top-post!

Second, do not send HTML, the only plain text is what is considered.

> On Wed, Jul 1, 2026 at 11:42 AM Bohdan Derkach <bohdandmarcus@gmail.com> wrote:

> > You are completely right about the indentation and line wraps. Dan
> > Carpenter also pointed this out to me yesterday, and I have already
> > prepared a v4 that fixes all of these issues perfectly. I am strictly
> > following the rule to wait a full 24 hours between sending versions, so I
> > will send v4 later today.
> >
> > Regarding your question about whether this is the only issue in the driver:
> > I understand that sending a patch for a single block comment in a 100k LoC
> > driver is a very small contribution. Since this is my very first patch to
> > the Linux kernel, my main goal was to learn the correct workflow (git
> > send-email, formatting versions, acting on feedback) before sending larger
> > patch series.
> >
> > Once this v4 is accepted and I am confident that my setup is correct, my
> > next step is to grep through the rest of atomisp to fix similar block
> > comments and submit them as a proper patch series.

It really doesn't matter if this is a single place fix or not, the part of
the process is to try to fix the whole class of the problems at once.

Also check that your code is based on latest and greatest maintainer's tip.
(It's located somewhere on git.linuxtv.org with atomisp in the tree name.)

> > Thank you for your patience and for guiding a newcomer!

You're welcome.

> > On Wed, Jul 1, 2026 at 11:31 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >>
> >> On Tue, Jun 30, 2026 at 7:06 PM Bohdan D. Marcus
> >> <bohdandmarcus@gmail.com> wrote:
> >> >
> >> > Fix a block comment formatting warning reported by
> >> > checkpatch.pl in atomisp_cmd.c to conform to the
> >> > Linux kernel coding style.
> >>
> >> Almost the same comments as per v2. Please, slow down, read other
> >> comments and act accordingly.

-- 
With Best Regards,
Andy Shevchenko