[PATCH] ALSA: control: Drop redundant stream_open() return check

[PATCH] ALSA: control: Drop redundant stream_open() return check

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

The previous conversion from nonseekable_open() to stream_open() retained
the existing error check.
Since stream_open() always returns 0, remove the dead error handling path.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/core/control.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/core/control.c b/sound/core/control.c
index 7a8dc506221e..4cfb0be14c92 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -56,8 +56,6 @@ static int snd_ctl_open(struct inode *inode, struct file *file)
 	int i, err;
 
 	err = stream_open(inode, file);
-	if (err < 0)
-		return err;
 
 	card = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_CONTROL);
 	if (!card) {
-- 
2.43.0

Re: [PATCH] ALSA: control: Drop redundant stream_open() return check

[Cezary Rojewski]

On 7/2/2026 6:46 AM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> The previous conversion from nonseekable_open() to stream_open() retained
> the existing error check.
> Since stream_open() always returns 0, remove the dead error handling path.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>   sound/core/control.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/sound/core/control.c b/sound/core/control.c
> index 7a8dc506221e..4cfb0be14c92 100644
> --- a/sound/core/control.c
> +++ b/sound/core/control.c
> @@ -56,8 +56,6 @@ static int snd_ctl_open(struct inode *inode, struct file *file)
>   	int i, err;
>   
>   	err = stream_open(inode, file);
> -	if (err < 0)
> -		return err;

This is a good catch Phuc!  Typically such conversions are discouraged 
as things may change in time but in stream_open() case its documentation 
clearly states: the function never fails.

While not drop the assignment altogether?

>   
>   	card = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_CONTROL);
>   	if (!card) {

Re: [PATCH] ALSA: control: Drop redundant stream_open() return check

[Bui Duc Phuc]

Hi Cezary,

Thanks for the review!

>
> This is a good catch Phuc!  Typically such conversions are discouraged
> as things may change in time but in stream_open() case its documentation
> clearly states: the function never fails.
>

I'm just starting to dig deeper into the ALSA core.
Luckily, the very first function I looked at already turned into a patch. :)

I had already received a similar review from Takashi and sent a v2 series.
https://lore.kernel.org/all/20260702084445.519669-1-phucduc.bui@gmail.com/

Your review and Takashi-san's pointed out the same issue.
Thanks to both of you!

Best,
Bui Duc Phuc