From: Jason Gunthorpe <jgg@nvidia.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Ankit Agrawal <ankita@nvidia.com>,
gregkh@linuxfoundation.org, jai.luthra@ideasonboard.com,
ilpo.jarvinen@linux.intel.com, alex@shazbot.org,
vsethi@nvidia.com, mhonap@nvidia.com, mochs@nvidia.com,
clg@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] platform/nvidia: Introduce nvgrace-egm driver and enumerate EGM regions
Date: Fri, 3 Jul 2026 10:59:24 -0300 [thread overview]
Message-ID: <20260703135924.GP7481@nvidia.com> (raw)
In-Reply-To: <19799c78-f9ac-44e0-aedf-6c7bca77c15d@gmx.de>
On Fri, Jul 03, 2026 at 12:22:21AM +0200, Armin Wolf wrote:
> > - Walk all PCI devices at module init time. For each one advertising
> > "nvidia,egm-pxm", read the EGM region properties (base SPA, size and
> > PXM domain) from the ACPI DSD table via the GPU device handle, using
> > "nvidia,egm-base-pa" and "nvidia,egm-size" properties.
> > - Maintain a module-level list (egm_chardevs) of discovered regions,
> > de-duplicating by PXM so each socket gets exactly one EGM device
> > regardless of how many GPUs it has (2 GPUs per EGM device in GB200).
>
> I assume that the PCI device itself is being handled by the GPU driver, right?
> In this case i suggest that you do the discovery inside the GPU driver during probing,
> otherwise you might run intro problems once PCI hotplug comes into play.
IMHO the ACPI modeling placing the egm-base-pa under the PCI device is
not really very good (but we are stuck with it). The EGM is an
entirely distinct object from the PCI device. The ACPI is just saying
that the PCI device has efficient access to the EGM.
It wouldn't make any sense to involve the GPU driver since the GPU
driver doesn't even run on the hypervisor.
Jason
next prev parent reply other threads:[~2026-07-03 13:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:25 [PATCH 0/4] Introduce nvgrace-egm driver for Extended GPU Memory Ankit Agrawal
2026-07-02 19:25 ` [PATCH 1/4] platform/nvidia: Introduce nvgrace-egm driver and enumerate EGM regions Ankit Agrawal
2026-07-02 22:22 ` Armin Wolf
2026-07-03 13:59 ` Jason Gunthorpe [this message]
2026-07-02 19:25 ` [PATCH 2/4] platform/nvidia: Implement mmap and memory scrubbing for EGM chardev Ankit Agrawal
2026-07-02 19:25 ` [PATCH 3/4] platform/nvidia: Handle retired ECC pages and expose via ioctl Ankit Agrawal
2026-07-02 19:25 ` [PATCH 4/4] platform/nvidia: Register EGM PFNMAP range with memory_failure Ankit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703135924.GP7481@nvidia.com \
--to=jgg@nvidia.com \
--cc=W_Armin@gmx.de \
--cc=alex@shazbot.org \
--cc=ankita@nvidia.com \
--cc=clg@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhonap@nvidia.com \
--cc=mochs@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox